-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Brave Ads has arrived!" notification should be shown on Linux after upgrade from 0.62.x #4202
Milestone
Comments
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
77 tasks
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
"Brave Ads has arrived!" notification should be shown on Linux after upgrade from 0.62.x
Steps to Reproduce
Actual result:
"Brave Ads has arrived!" notification was not shown on Linux after upgrading from 0.62.x
Expected result:
"Brave Ads has arrived!" notification should be shown on Linux after upgrading from 0.62.x
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
0.63.x, 0.64.x, 0.65.x and 0.66.x
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
brave_ads_enabled
(https://github.com/brave/brave-core/blob/0.62.x/components/brave_ads/browser/buildflags/buildflags.gni) was set tofalse
on Linux for 0.62.xbrave_ads_enabled
(https://github.com/brave/brave-core/blob/0.63.x/components/brave_ads/browser/buildflags/buildflags.gni) was set totrue
for Linux on 0.63.xAnd the upgrade path assumed this value would always be
true
for all platforms when migrating.The text was updated successfully, but these errors were encountered: