ipfs companion options page cannot be shown

[yrliou]

Description

IPFS companion has an extension option page which includes various options users could set for the extension. Because right now we installed it as a component extension if users install it using the switch in brave://settings, the extension cannot be shown in brave://extensions unless we manually pass an argument when execute the binary.

Steps to Reproduce

1. Visit brave://settings and toggle IPFS companion switch
2. Right click IPFS companion extension icon and click options.

Actual result:

Option page is not shown.

Expected result:

Should show the option page as below

Reproduces how often:

Every time

Brave version (brave://version info)

This exists starting from 0.64.x where IPFS switch is landed.

[yrliou]

Test plan specified in brave/brave-core#2328 (comment)

[lidel]

@yrliou would it make things better if we open Preferences in a new tab? (so far been low on our priority list, but we can bump it: ipfs/ipfs-companion#502)

Or is this related to the way runtime​.open​Options​Page() is handled in component extensions?

[yrliou]

@lidel If Preferences is opened as an extension page in a new tab, then we won't have problem showing it by either installing as a component extension or a regular extension.
The reason it cannot be shown if installing as a component extension is because the extension page (chrome://extensions or brave://extensions) where the overlay will be in will not show any component extensions by default.
Because installing as a normal extension gives us the benefit for manifest localization and solves this issue, I don't think we need to bump the priority of ipfs/ipfs-companion#502 for this.

[GeetaSarvadnya]

Verification passed on

Brave	0.64.68 Chromium: 74.0.3729.108 (Official Build) beta (64-bit)
Revision	daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS	Windows 10 OS Build 17134.523

• Verified the test plan from Install ipfs as a normal extension brave-core#2328 (comment)

Verification passed on

Brave	0.64.68 Chromium: 74.0.3729.108 (Official Build) beta (64-bit)
Revision	daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS	Linux

• Verified the test plan from Install ipfs as a normal extension brave-core#2328 (comment)
• Logged Maximize and minimize window options not required in Add IPFS companion popup #4297

Verified passed with

Brave	0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision	518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS	Mac OS X

• Verified test plan from Install ipfs as a normal extension brave-core#2328