Install ipfs as a normal extension #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
force-pushed
the
install_ipfs_as_extension
branch
from
4f04181
to
2991d54
Compare
emerick
previously approved these changes
Apr 24, 2019
| @@ -83,6 +85,15 @@ void BraveDefaultExtensionsHandler::SetHangoutsEnabled( | |||
| } | |||
| } | |||
|
|
|||
| bool BraveDefaultExtensionsHandler::IsExtensionInstalled( | |||
| const std::string extension_id) { | |||
There was a problem hiding this comment.
I think you probably want const std::string& here?
| @@ -25,6 +25,8 @@ class BraveDefaultExtensionsHandler : public settings::SettingsPageUIHandler { | |||
| void SetHangoutsEnabled(const base::ListValue* args); | |||
| void SetIPFSCompanionEnabled(const base::ListValue* args); | |||
|
|
|||
| bool IsExtensionInstalled(const std::string extension_id); | |||
This was referenced Apr 24, 2019
brave-builds
pushed a commit
that referenced
this pull request
Apr 24, 2019
brave-builds
pushed a commit
that referenced
this pull request
Apr 24, 2019
This was referenced Apr 24, 2019
|
@yrliou Step 5: Toggle IPFS off again - do you mean off the IPFS from below popup? If so, after making IPFS off, IPFS companion extension is NOT disabled in brave://extensions. Can you please clarify the point 5 in the above test plan? Thanks!
|
|
@GeetaSarvadnya No, it is not the option page but the switch we introduced in brave://settings. I've updated step 5 to be more clear, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#3950
Fix brave/brave-browser#4218
Instead of installing as a component extension, this PR installs ipfs companion using a webstore installer so manifest could be localized and the extension option page could be shown normally under brave://extensions.
Toggle on the switch would prompt to install IPFS companion extension if it was't installed before. If already installed, it will enable the extension.
Toggle off the switch would disable IPFS companion extension (but not uninstall it). To fully remove (uninstall) the IPFS companion extension after it is installed, remove the extension through brave://extensions.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Click "Cancel" in the prompt, the IPFS companion switch should be changed back to off.
Toggle it on again, and click "Add extension" in the prompt to install it, IPFS companion extension should now be installed and enabled.
Right click IPFS companion switch icon to open options page, it should shown as
In brave://settings, toggle IPFS companion switch off again and visit brave://extensions, IPFS companion extension should be shown disabled.
Enable the IPFS companion switch toggle in brave://settings again, IPFS companion extension should be shown enabled in brave://extensions.
Remove IPFS companion extension in brave://extensions, IPFS companion extension switch toggle in brave://settings should be shown off.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.