Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS companion extension is not removed from brave://components #4211

Closed
btlechowski opened this issue Apr 24, 2019 · 2 comments
Closed

IPFS companion extension is not removed from brave://components #4211

btlechowski opened this issue Apr 24, 2019 · 2 comments

Comments

@btlechowski
Copy link

Follow up to #3918
Found when verifying test plan from brave/brave-core#2106

Steps to Reproduce

  1. Clean install
  2. Open brave://settings/?search=ipfs
  3. Toggle IPFS Companion on
  4. Wait till the extension is installed
  5. Toggle IPFS Companion off
  6. Check brave://components/ for IPFS Companion

Actual result:

IPFS Companion is listed in brave://components/

Note: Browser restart removes the extension

Expected result:

IPFS Companion is NOT listed in brave://components/ per brave/brave-core#2106

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

cc @brave/legacy_qa @yrliou

@yrliou
Copy link
Member

yrliou commented Apr 24, 2019

Per currently impl it will be disabled but not totally gone in that page before restart, I might write a wrong expected result in the test plan, sorry about that.
This will no longer be an issue soon since we're changing to install it as a normal extension in brave/brave-core#2328.

@yrliou
Copy link
Member

yrliou commented Apr 25, 2019

Closing as not actionable since IPFS companion is not a component extension anymore in 0.64.x and later.

@yrliou yrliou closed this as completed Apr 25, 2019
@yrliou yrliou added this to the Dupe / Invalid / Not actionable milestone Apr 25, 2019
@yrliou yrliou assigned yrliou and unassigned yrliou Apr 25, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 9, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants