Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a switch for IPFS companion extension #3918

Closed
yrliou opened this issue Mar 28, 2019 · 3 comments · Fixed by brave/brave-core#2106
Closed

Add a switch for IPFS companion extension #3918

yrliou opened this issue Mar 28, 2019 · 3 comments · Fixed by brave/brave-core#2106

Comments

@yrliou
Copy link
Member

yrliou commented Mar 28, 2019

Test plan

See brave/brave-core#2106

Description

Add a pref to control IPFS companion extension installation, which will be off by default.

@yrliou yrliou self-assigned this Mar 28, 2019
@rebron rebron added the support addition/edits to articles on support website label Mar 28, 2019
@rebron
Copy link
Collaborator

rebron commented Mar 28, 2019

cc: @Brave-Matt We're going to need an article to explain this switch and IPFS in general.

@bsclifton
Copy link
Member

Updated top post to link to test plan 😄
cc: @yrliou

@btlechowski
Copy link

btlechowski commented Apr 24, 2019

Verification passed on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#2106
verified that user cannot install ipfs extension from Google webstore when ipfs is already installed through the toggle

Logged #4211 and #4212
Encountered while testing #3950

Verification passed on

Brave 0.64.68 Chromium: 74.0.3729.108 (Official Build) beta (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Linux

Verified passed with

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants