Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install ipfs as a normal extension (uplift to 0.65.x) #2333

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Install ipfs as a normal extension (uplift to 0.65.x) #2333

merged 1 commit into from
Apr 25, 2019

Conversation

brave-builds
Copy link
Collaborator

Uplift of #2328

@brave-builds brave-builds self-assigned this Apr 24, 2019
@brave-builds brave-builds added this to the 0.65.x - Dev milestone Apr 24, 2019
@yrliou yrliou requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv April 24, 2019 17:51
@bbondy
Copy link
Member

bbondy commented Apr 25, 2019

Please test on a nightly build before merging and also check that it passes CI.

@yrliou
Copy link
Member

yrliou commented Apr 25, 2019

Tested on nightly, looks good.
CI lint failed at components/brave_ads/browser/locale_helper_win.cc:30: Add #include for unique_ptr<> [build/include_what_you_use] [4] which is irrelevant to this PR.
Merging.

@yrliou yrliou merged commit 88b9236 into 0.65.x Apr 25, 2019
@yrliou yrliou deleted the pr2328_install_ipfs_as_extension_0.65.x branch April 25, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
0.65.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @bbondy @yrliou @brave-browser-releases