Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus indicator in shields panel is trimmed #4225

Open
btlechowski opened this issue Apr 25, 2019 · 4 comments
Open

Focus indicator in shields panel is trimmed #4225

btlechowski opened this issue Apr 25, 2019 · 4 comments
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Linux OS/Windows priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Change OS display scale to 125%
  2. Clean install
  3. Open a page
  4. Open shields panel
  5. Focus a toggle

Actual result:

Focus indicator is trimmed on the right side
image

Note: reproducible for Light and Dark theme

Expected result:

Focus indicator is not trimmed on the right side

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

cc @brave/legacy_qa @cezaraugusto

@btlechowski btlechowski added bug feature/shields The overall Shields feature in Brave. QA/Yes QA/Test-Plan-Specified feature/shields/panel Front-end design and functionality of the Shields panel. labels Apr 25, 2019
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Apr 26, 2019
@rebron
Copy link
Collaborator

rebron commented Apr 26, 2019

cc: @karenkliu

@kjozwiak
Copy link
Member

kjozwiak commented May 7, 2019

Went through the following:

  • macOS 10.14.4 x64 using 0.66.50 Chromium: 74.0.3729.131 - Couldn't reproduce
  • Mint 19.1 Tessa x64 using 0.66.50 Chromium: 74.0.3729.131 - Couldn't reproduce
  • Win 10 x64 using 0.66.50 Chromium: 74.0.3729.131 - Reproduced

macOS 10.14.4 x64 Example:

Screen Shot 2019-05-07 at 1 39 38 PM

Mint 19.1 Tessa x64 VM Example:

Screen Shot 2019-05-07 at 2 25 19 PM

Windows 10 x64 Example:

desktopShieldWin (1)

@kjozwiak
Copy link
Member

kjozwiak commented May 7, 2019

@srirambv can you reproduce this on your linux desktop?

@srirambv
Copy link
Contributor

srirambv commented May 8, 2019

This happens on switch when theme is set to light on Linux Desktop. The problem is the focus indicator on the edge of shields is half blocked as you can see the thickness is less on the shields panel edge compared to the side inside the panel

Dark theme
Screenshot from 2019-05-08 09-19-27
Screenshot from 2019-05-08 09-19-25
Screenshot from 2019-05-08 09-19-12

Light Theme
Screenshot from 2019-05-08 09-22-19
Screenshot from 2019-05-08 09-22-23
Screenshot from 2019-05-08 09-22-32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Linux OS/Windows priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

5 participants