Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the dark theme on the rewards page (dark mode) #4229

Closed
dizeeee opened this issue Apr 25, 2019 · 7 comments
Closed

Support the dark theme on the rewards page (dark mode) #4229

dizeeee opened this issue Apr 25, 2019 · 7 comments

Comments

@dizeeee
Copy link

dizeeee commented Apr 25, 2019

This is a pretty simple problem, the colors setting that can be found in the appearance section of the menu does not seem to apply to the rewards page. The styling for the rewards page needs to be updated to support it.

@NejcZdovc
Copy link
Contributor

+1 from #8926

@NejcZdovc NejcZdovc removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Apr 10, 2020
@eljuno
Copy link

eljuno commented Jun 30, 2020

Duplicate of #2822?

@NejcZdovc
Copy link
Contributor

let's keep it. Added link to this issue in #2822

@anji5h
Copy link

anji5h commented Jul 15, 2021

It's 2021 and still, the issue is not fixed.

@bsclifton
Copy link
Member

Hi folks

We are working on a new "2.0" interface for Rewards; you can track those issues with the rewards-ui-2.0 label. I've added this so we don't forget to include it in the scope of the work

@bsclifton bsclifton changed the title Support the dark theme on the rewards page Support the dark theme on the rewards page (dark mode) Aug 5, 2021
@Rybec
Copy link

Rybec commented Jul 13, 2022

Halfway through 2022, and it's still a problem.

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 29, 2022

We will be moving to a whole new Rewards interface in Rewards 3.0 (a "cards model" that unifies with the Brave Wallet interface). There, we will have a dark version of the UI, since the Brave Wallet UI in general always has a light/dark theme. Since that is on the horizon, I will close this particular issue as "wontfix", since I will take it as referring to the classic Rewards settings page.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants