Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark theme for settings page for Linux users #5098

Closed
Leon0402 opened this issue Jul 2, 2019 · 5 comments · Fixed by brave/brave-core#2905
Closed

Support dark theme for settings page for Linux users #5098

Leon0402 opened this issue Jul 2, 2019 · 5 comments · Fixed by brave/brave-core#2905

Comments

@Leon0402
Copy link

Leon0402 commented Jul 2, 2019

Description

On Linux, settings page, brave rewards etc. is still displayed in light theme.
It's unlikely that is has to do something with global settings as it's reproducible on different Linux distros with different desktop environments (gnome, kde, xfce).
See: https://community.brave.com/t/dark-theme-is-broken-or-incomplete/

Test plan / Steps to Reproduce

  1. Open settings page of brave on Linux (or brave rewards etc.)

Actual result:

Screenshot_20190702_170153

Expected result:

Should be dark.

Reproduces how often:

Always

Brave version (brave://version info)

Current release and beta release (0.66.x)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Not tested
  • Can you reproduce this issue with the nightly channel? Not tested
@simonhong simonhong self-assigned this Jul 3, 2019
@smcatala
Copy link

smcatala commented Jul 3, 2019

should the default ERR_CONNECTION_REFUSED page be dark as well ?
image

@simonhong
Copy link
Member

@smcatala No, that page is not dark-mode aware yet.

@srirambv srirambv added OS/Linux QA/Yes release-notes/include feature/user-interface All UI related priority/P4 Planned work. We expect to get to it "soon". labels Jul 3, 2019
@bsclifton
Copy link
Member

@simonhong does dark mode not work on Linux? I thought the Polymer pages would properly get the setting on all platforms... starting with Chromium 75?

The rewards page for sure is not done, but that is captured with #4229

@simonhong
Copy link
Member

simonhong commented Jul 11, 2019

@bsclifton On linux, only our native ui dark mode works and not the webui because linux os doesn't have dark mode setting like mac/windows. So, we can't see dark mode on chrome linux also.
But, I think I can handle it with our option. (win7/win8 also)

@btlechowski
Copy link

Verification passed on

Brave 0.69.117 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verified STR from the description.

image
image
image
image

@rebron rebron changed the title Dark Mode broken on Linux Support dark theme for settings page for Linux users Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants