Refactoring brave theme related modules #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
refactoring_brave_theme
branch
5 times, most recently
from
5317fe9 to
346db29
Compare
simonhong
force-pushed
the
refactoring_brave_theme
branch
3 times, most recently
from
d4f484b to
bea8809
Compare
simonhong
force-pushed
the
refactoring_brave_theme
branch
2 times, most recently
from
544decb to
6092379
Compare
Enable webui/base native dark mode on platforms that doesn't support system dark mode like win7/win8/linux/mac high sierra.
gtk theme is considered as a different theme type. Also, classic theme is set by default insted of gtk theme for using whole brave theme as a default.
simonhong
force-pushed
the
refactoring_brave_theme
branch
from
e561add to
6bc2c3f
Compare
petemill
approved these changes
Jul 17, 2019
There was a problem hiding this comment.
Thanks for fixing all the linux issues and making the code more understandable @simonhong.
I noticed in your screenshot that the Windows titlebar seems lighter than I remember seeing. Is that a change from this branch?
|
@petemill Our title bar background is not used on Win8. I don't know the reason for now. Needs investigate. Maybe Win8 doesn't allow it? (not sure). I think it has been around for long time. |
This was referenced Jul 24, 2019
This was referenced Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable dark mode of webui/base native ui on platforms that doesn't support system dark mode like win7/win8/linux/mac high sierra.
On linux, gtk theme is considered as a different theme.
So, when user chooses gtk theme instead of classic, it is respected instead of brave theme color for native.
Fix brave/brave-browser#3793
Fix brave/brave-browser#5098
Fix brave/brave-browser#4637
Fix brave/brave-browser#965
Dark at Ubuntu
gtk theme at Ubuntu with dark
classic theme at Ubuntu with dark
Dark at Win8
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
yarn test brave_browser_tests --filter=BraveThemeServiceTest.NativeThemeObserverTestReviewer Checklist:
After-merge Checklist:
changes has landed on.