-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dark theme mismatch for some UI items on older OSes #4637
Comments
I think this wouldn't be fixed because upstream chromium only support dark mode to native ui(ex menu) or webui for Mojave. |
Given what @simonhong mentioned, I tagged with a |
Thanks @bsclifton @simonhong A user noted this also happens on their Linux machine - https://community.brave.com/t/different-background-color-in-the-settings-page-on-different-platform/63243 |
@LaurenWags Yup, this is expected behavior for current upstream implementation. |
@LaurenWags I think this also can be happened on older Windows like Win7 and Win8 because they don't support dark mode. Can you check this on Win7 and Win8 also? |
@simonhong I don't have Win 8, but I can confirm this also happens for Win 7. Brave 0.64.77 Chromium: 74.0.3729.169 (Official Build) (64-bit) |
I can reproduce this on Win10 in both Nightly and Release builds. I have another user here confirming Laurens initial report: |
@Brave-Matt Thanks for checking this on Nightly on Windows.
Sorry for the noise. Nightly is different thing with this issue. Will create new issue. |
Dark mode works awesome! Great work! Verification passed on
Verified steps from the description. Verified passed with
Verification passed on
Verified steps from the description. |
Description
On older OS such as High Sierra, Chromium items (web ui, menus) do not go dark to match selected theme but Brave specific items (shields, toolbar) do.
Newer OSes (such as Mojave) do not have this problem.
Test plan / Steps to Reproduce
Actual result:
Hamburger menu and page backgrounds do not match dark theme.
Expected result:
Hamburger menu and page backgrounds should match dark theme as shields and toolbar do.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
Some screenshots of how Mojave behaves can be found here: #3965 (comment)
The text was updated successfully, but these errors were encountered: