Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions installed from should have a generic name #1013

Closed
srirambv opened this issue Sep 7, 2018 · 1 comment · Fixed by brave/brave-core#1080
Closed

Extensions installed from should have a generic name #1013

srirambv opened this issue Sep 7, 2018 · 1 comment · Fixed by brave/brave-core#1080
Labels
feature/extensions feature/global-settings Settings at browser level independent of shields settings QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 7, 2018

Description

Extensions installed from should have a generic name

Steps to Reproduce

  1. Install any extension from CWS
  2. Open chrome://extensions and click on details
  3. Source shows Brave web store

Actual result:

image

Expected result:

image

Reproduces how often:

Easy

Brave version (about:brave info)

Brave 0.55.1 Chromium: 70.0.3528.4 (Official Build) dev (64-bit)
Revision 1911f781145b803e04f2d0b5b1a0146ae69fcbdc-refs/branch-heads/3528@{#9}
OS Windows

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@srirambv srirambv added feature/extensions feature/global-settings Settings at browser level independent of shields settings labels Sep 7, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Sep 7, 2018
@srirambv srirambv mentioned this issue Sep 7, 2018
Closed
@srirambv srirambv mentioned this issue Dec 13, 2018
Closed
mkarolin added a commit to brave/brave-core that referenced this issue Dec 13, 2018
@mkarolin
Updates extensions store link language on the extensions page. Adds
884612c 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
@mkarolin mkarolin mentioned this issue Dec 13, 2018
Merged
18 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Dec 14, 2018
@mkarolin
Updates extensions store link language on the extensions page. Adds
d490716 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
mkarolin added a commit to brave/brave-core that referenced this issue Dec 25, 2018
@mkarolin
Updates extensions store link language on the extensions page. Adds
7d3a0f9 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
mkarolin added a commit to brave/brave-core that referenced this issue Jan 7, 2019
@mkarolin
Updates extensions store link language on the extensions page. Adds
8eb4a05 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
mkarolin added a commit to brave/brave-core that referenced this issue Jan 8, 2019
@mkarolin
Updates extensions store link language on the extensions page. Adds
1f89663 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
mkarolin added a commit to brave/brave-core that referenced this issue Jan 8, 2019
@mkarolin
Updates extensions store link language on the extensions page. Adds
655f19c 
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
This was referenced Jan 8, 2019
Merged
Merged
@mkarolin mkarolin modified the milestones: 1.x Backlog, 0.59.x - Beta Jan 14, 2019
This was referenced Jan 16, 2019
Closed
Closed
@btlechowski
Copy link

btlechowski commented Jan 17, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

image

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

image

Verified passed with

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Mac OS X

screen shot 2019-01-18 at 10 38 12 am

@GeetaSarvadnya GeetaSarvadnya mentioned this issue May 22, 2019
Closed
@VMBindraban VMBindraban mentioned this issue May 23, 2019
Closed
@bughit bughit mentioned this issue May 26, 2019
Closed
@edSarti edSarti mentioned this issue May 27, 2019
Closed
@Pablete1234 Pablete1234 mentioned this issue May 31, 2019
Open
@foamz foamz mentioned this issue May 31, 2019
Closed
@Brave-Matt Brave-Matt mentioned this issue May 31, 2019
Closed
This was referenced Jun 1, 2019
Closed
Open
@Ravendwyr Ravendwyr mentioned this issue Jun 2, 2019
Closed
@ghost ghost mentioned this issue Jun 2, 2019
Open
@mwdiers mwdiers mentioned this issue Jun 3, 2019
Closed
@bibodha bibodha mentioned this issue Jun 4, 2019
Closed
@fish2eggs fish2eggs mentioned this issue Jun 4, 2019
Open
@sbtnc sbtnc mentioned this issue Jun 4, 2019
Open
@LaurenWags LaurenWags mentioned this issue Jun 4, 2019
Closed
@norsehealer norsehealer mentioned this issue Jun 6, 2019
Closed
@YvanDaSilva YvanDaSilva mentioned this issue Jun 6, 2019
Closed
@brhaka brhaka mentioned this issue Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/extensions feature/global-settings Settings at browser level independent of shields settings QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Change link text on extensions page. brave/brave-core
5 participants
@kjozwiak @srirambv @LaurenWags @btlechowski @mkarolin