-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change link text on extensions page. #1080
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
force-pushed
the
maxk-find-extensions-text
branch
2 times, most recently
from
December 13, 2018 04:13
f0802d1
to
64ef8e8
Compare
mkarolin
changed the title
WIP: Change link text on extensions page.
Change link text on extensions page.
Dec 13, 2018
mkarolin
changed the title
Change link text on extensions page.
WIP: Change link text on extensions page.
Dec 13, 2018
mkarolin
force-pushed
the
maxk-find-extensions-text
branch
from
December 13, 2018 14:10
64ef8e8
to
884612c
Compare
mkarolin
changed the title
WIP: Change link text on extensions page.
Change link text on extensions page.
Dec 13, 2018
yrliou
reviewed
Dec 13, 2018
bbondy
requested changes
Dec 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep per @yrliou 's comment.
mkarolin
force-pushed
the
maxk-find-extensions-text
branch
3 times, most recently
from
December 14, 2018 04:14
db1791e
to
d490716
Compare
mkarolin
force-pushed
the
maxk-find-extensions-text
branch
from
December 25, 2018 02:23
d490716
to
7d3a0f9
Compare
link to the store even if there are installed extensions. Fixes brave/brave-browser#2497 Fixes brave/brave-browser#1013
mkarolin
force-pushed
the
maxk-find-extensions-text
branch
from
January 7, 2019 22:05
7d3a0f9
to
8eb4a05
Compare
yrliou
approved these changes
Jan 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jan 8, 2019
bbondy
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates extensions store link language on the extensions page. Adds
link to the store even if there are installed extensions.
Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
You don't have any extensions yet. Would you like to [install some]
?,install some
takes you to the Chrome Web Store,Looking for even more extensions?
,Web Extensions Store
.Reviewer Checklist: