Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change link text on extensions page. #1080

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 13, 2018

Updates extensions store link language on the extensions page. Adds
link to the store even if there are installed extensions.

Fixes brave/brave-browser#2497
Fixes brave/brave-browser#1013

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • Start Brave with a fresh profile,
  • Navigate to brave://extensions,
  • Verify that the page shows text You don't have any extensions yet. Would you like to [install some]?,
  • Verify that clicking on install some takes you to the Chrome Web Store,
  • Add one or more extensions,
  • Return to brave://extensions page,
  • Verify that the page shows text Looking for even more extensions?,
  • Verify that clicking on the text takes you to the Chrome Web Store,
  • Return to brave://extensions page,
  • Click on Details button for any extension installed from Chrome Web Store,
  • On the details page, verify that the Source shows text Web Extensions Store.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mkarolin mkarolin force-pushed the maxk-find-extensions-text branch 2 times, most recently from f0802d1 to 64ef8e8 Compare December 13, 2018 04:13
@mkarolin mkarolin self-assigned this Dec 13, 2018
@mkarolin mkarolin changed the title WIP: Change link text on extensions page. Change link text on extensions page. Dec 13, 2018
@mkarolin mkarolin requested review from yrliou and bbondy December 13, 2018 04:18
@mkarolin mkarolin changed the title Change link text on extensions page. WIP: Change link text on extensions page. Dec 13, 2018
@mkarolin mkarolin force-pushed the maxk-find-extensions-text branch from 64ef8e8 to 884612c Compare December 13, 2018 14:10
@mkarolin mkarolin changed the title WIP: Change link text on extensions page. Change link text on extensions page. Dec 13, 2018
@mkarolin mkarolin requested a review from darkdh December 13, 2018 18:14
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep per @yrliou 's comment.

@mkarolin mkarolin force-pushed the maxk-find-extensions-text branch from 7d3a0f9 to 8eb4a05 Compare January 7, 2019 22:05
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin mkarolin merged commit 59c01ef into master Jan 10, 2019
@mkarolin mkarolin deleted the maxk-find-extensions-text branch January 10, 2019 15:49
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change Find extensions and Themes text Extensions installed from should have a generic name
3 participants