Change "Brave Web Store" strings to "Web Store" #2983
Assignees
Labels
Milestone
Comments
mkarolin
added a commit
that referenced
this issue
Jan 16, 2019
'Web Store' in order to avoid ending up with 'Brave Web Store' when 'Chrome' is globally replaced with 'Brave'. Fixes #2983
18 tasks
16 tasks
mkarolin
added a commit
to brave/brave-core
that referenced
this issue
Jan 16, 2019
IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS due to localization issues. - Updates extensions web UI page to use the default Chromium string instead of the removed IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS. - Reverts patch that made those strings accessible to the web UI. - Includes updated .grd[p] files resulting from running chromium_rebase_l10n as a part of fix for brave/brave-browser#2983. Fixes brave/brave-browser#2982 Fixes brave/brave-browser#2983
mkarolin
added a commit
that referenced
this issue
Jan 16, 2019
'Web Store' in order to avoid ending up with 'Brave Web Store' when 'Chrome' is globally replaced with 'Brave'. Fixes #2983
mkarolin
added a commit
to brave/brave-core
that referenced
this issue
Jan 16, 2019
IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS due to localization issues. - Updates extensions web UI page to use the default Chromium string instead of the removed IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS. - Reverts patch that made those strings accessible to the web UI. - Includes updated .grd[p] files resulting from running chromium_rebase_l10n as a part of fix for brave/brave-browser#2983. Fixes brave/brave-browser#2982 Fixes brave/brave-browser#2983
mkarolin
added a commit
to brave/brave-core
that referenced
this issue
Jan 16, 2019
IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS due to localization issues. - Updates extensions web UI page to use the default Chromium string instead of the removed IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS. - Reverts patch that made those strings accessible to the web UI. - Includes updated .grd[p] files resulting from running chromium_rebase_l10n as a part of fix for brave/brave-browser#2983. Fixes brave/brave-browser#2982 Fixes brave/brave-browser#2983
mkarolin
added a commit
that referenced
this issue
Jan 16, 2019
'Web Store' in order to avoid ending up with 'Brave Web Store' when 'Chrome' is globally replaced with 'Brave'. Fixes #2983
This was referenced Jan 16, 2019
|
Verification passed on
Used test plan from brave/brave-core#1358
Verification passed on
Verification PASSED on
|
petemill
pushed a commit
to brave/brave-core
that referenced
this issue
Jul 27, 2020
'Web Store' in order to avoid ending up with 'Brave Web Store' when 'Chrome' is globally replaced with 'Brave'. Fixes brave/brave-browser#2983
petemill
pushed a commit
to brave/brave-core
that referenced
this issue
Jul 28, 2020
'Web Store' in order to avoid ending up with 'Brave Web Store' when 'Chrome' is globally replaced with 'Brave'. Fixes brave/brave-browser#2983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because of localization issues with string containing tags and consequently brave/brave-core#1080 (which fixed #1013 and #2497) being reverted (by #2982), strings showing "Brave Web Store" would show up on Extensions page and elsewhere. We need to apply the same fix as was done in #2625 to 0.59.x and above - replace
Chrome Web Storeto justWeb Store, so that it doesn't get affected by global replacement of Chrome with Brave.The text was updated successfully, but these errors were encountered: