Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Brave Web Store with Web Store in 0.58.x release. #2625

Closed
mkarolin opened this issue Dec 18, 2018 · 5 comments
Closed

Replace Brave Web Store with Web Store in 0.58.x release. #2625

mkarolin opened this issue Dec 18, 2018 · 5 comments
Assignees
@mkarolin
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.58.x - Release ...

Comments

@mkarolin
Copy link
Contributor

Since #2497 fix won't make it to 0.58.x we still want to patch the string without needing to redo the localization. For 0.58.x we will just replace "Brave Web Store" with "Web Store" globally which won't require localization changes.

cc: @rebron
@mkarolin mkarolin self-assigned this Dec 18, 2018
mkarolin added a commit to brave/brave-core that referenced this issue Dec 18, 2018
@mkarolin
Result of running 'npm run chromium_rebase_l10n' after adding
a5c6022 
a global replacement for 'Brave Web Store' with just 'Web Store'
in brave-browser/lib/l10nUtil.js

Fixes brave/brave-browser#2625
mkarolin added a commit that referenced this issue Dec 18, 2018
@mkarolin
Adds an entry to replace 'Chrome Web Store' with just
37c0113 
'Web Store' in l10Util.js.

Fixes #2625
This was referenced Dec 18, 2018
Merged
Merged
@mkarolin mkarolin added this to the 0.58.x - Release milestone Dec 18, 2018
@rushilsrivastava
Copy link

Can the support URLs also be updated accordingly, reported in #2457

@rebron
Copy link
Collaborator

rebron commented Dec 19, 2018

@mkarolin per discussion in triage, marking uplift-approved, let's get this merged to 58.x.

@mkarolin
Copy link
Contributor Author

Merged to 0.58.x.
@rebron @bbondy based on the number of strings replaced, it might make sense to apply this change to 0.59.x and above as well, since brave/brave-core#1080 won't affect all of these strings.

@mkarolin
Copy link
Contributor Author

Fixed

@LaurenWags
Copy link
Member

LaurenWags commented Dec 19, 2018 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.58.16 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

Verified passed with

Brave 0.58.16 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

Verification passed on

Brave 0.58.16 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

image
image

Verification passed on

Brave 0.58.16 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 10

image

@mkarolin mkarolin mentioned this issue Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

No branches or pull requests
6 participants
@kjozwiak @rebron @rushilsrivastava @LaurenWags @btlechowski @mkarolin