Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Brave Web Store" with "Web Store" in 0.58.x #1133

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 18, 2018

Result of running npm run chromium_rebase_l10n after adding
a global replacement for 'Brave Web Store' with just 'Web Store'
in brave-browser/lib/l10nUtil.js

Fixes brave/brave-browser#2625
in conjunction with brave/brave-browser#2626

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • Start Brave with a fresh profile,
  • Navigate to brave://extensions,
  • Verify that the page shows text Find extensions and themes in [Web Store]?,
  • Verify that clicking on Web Store takes you to the Chrome Web Store,
  • Add an extension from the store,
  • Return to brave://extensions page,
  • Click on Details button for any extension installed from Chrome Web Store,
  • On the details page, verify that the Source shows text Web Store.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

a global replacement for 'Brave Web Store' with just 'Web Store'
in brave-browser/lib/l10nUtil.js

Fixes brave/brave-browser#2625
@mkarolin mkarolin self-assigned this Dec 18, 2018
@mkarolin mkarolin changed the title WIP: Replace "Brave Web Store" with "Web Store" in 0.58.x Replace "Brave Web Store" with "Web Store" in 0.58.x Dec 18, 2018
@mkarolin mkarolin requested a review from bbondy December 18, 2018 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants