Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't load unused built-in extensions #4612

Closed
bughit opened this issue May 26, 2019 · 4 comments
Closed

don't load unused built-in extensions #4612

bughit opened this issue May 26, 2019 · 4 comments

Comments

@bughit
Copy link

bughit commented May 26, 2019

Description

In addition to rewards (#3436), the following extensions/processes should not be loaded when their functionality is not activated.

  • Utility: Bat Ledger Service (nothing related to BAT has been activated)
  • Utility: Bat Ads Service (nothing related to BAT has been activated)
  • Extension: Brave Sync (sync has not been activated)

PDF viewer, can probably be covered by #4350 (load on demand and unload when not in use)

Brave version (brave://version info)

Brave: 0.64.77 Chromium: 74.0.3729.169 (Official Build) (64-bit)
Revision: 78e4f8db3ce38f6c26cf56eed7ae9b331fc67ada-refs/branch-heads/3729@{#1013}
OS: Windows 7 Service Pack 1 Build 7601.24443

@rebron
Copy link
Collaborator

rebron commented Jun 7, 2019

Closing as a duplicate of #3436 where we'll handle thee cases as well. I'll +1 #3436 too.
PDF should no longer be an issue.

@bughit
Copy link
Author

bughit commented Oct 24, 2019

@rebron @petemill

This issue was closed as a dup of #3436, but the fix (brave/brave-core#3698) appears to be rewards specific. If that's the case, please reopen.

@bughit
Copy link
Author

bughit commented Nov 13, 2019

@rebron Is there a problem with reopening this? #3436 is fixed in 1.0 but this isn't.

@bsclifton
Copy link
Member

bsclifton commented Dec 31, 2019

@bughit sorry for the long turn-around on a response ☹️ The functionality you're looking for should be covered with #5429 👍 (which you've already found and commented on)

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants