Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some url bar icons are rounded #4655

Open
Pablete1234 opened this issue May 31, 2019 · 3 comments
Open

Some url bar icons are rounded #4655

Pablete1234 opened this issue May 31, 2019 · 3 comments
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@Pablete1234
Copy link

Description

The icons in the search bar are inconsistent, the ones that come from chromium were changed and now are now rounded, while brave icons remain correctly square like other parts of the GUI, like the URL bar itself.

Steps to Reproduce

  1. Open any web page

  2. Hover on the "lock" icon in the url bar

  3. Open a brave page, like settings or brave://version

  4. Hover on the "Brave" icon in the url bar

  5. Open a PDF file in brave

  6. Hover on the "PDF" icon in the url bar

Actual result:

image
image
image

Expected result:

All icons should be square, like brave-added icons
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.64.77 Chromium: 74.0.3729.169 (Official Build) (64-bit)
Revision 78e4f8db3ce38f6c26cf56eed7ae9b331fc67ada-refs/branch-heads/3729@{#1013}
OS Windows 7 Service Pack 1 Build 7601.24411

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Untested
  • Can you reproduce this issue with the dev channel? Untested
  • Can you reproduce this issue with the nightly channel? Untested

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome?
    Chrome has no inconsistency between different buttons on the bar, as all of the ones provided by chrome are round, and so is the URL bar. This bug itself comes from the fact that chromium upsteam changed to round icons.
    Brave uses a square url bar, so it makes sense that url icons should also be square.
@rebron rebron added design A design change, especially one which needs input from the design team priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Jun 7, 2019
@msmarrow
Copy link

Hello, is anybody currently working on this? if not, I would like to be assigned to it.

@bsclifton
Copy link
Member

Hi @msmarrow - nobody currently working on it. It's all yours!

If you haven't already gotten setup, please check out our wiki with steps on getting setup locally for development:
https://github.com/brave/brave-browser/wiki

@ghost
Copy link

ghost commented Jun 23, 2021

Has anything gone forward with this? No Chromium-inherited icons (like the secure connection icon in the URL bar) have changed since this was opened in 2019, or that it was moved to OS/Desktop in 2020.

@rebron rebron moved this to P5 backlog in Front End May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
Status: P5 backlog
Development

No branches or pull requests

4 participants