Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme change doesn't update URL bar until mouse over #5462

Closed
srirambv opened this issue Jul 30, 2019 · 3 comments
Closed

Theme change doesn't update URL bar until mouse over #5462

srirambv opened this issue Jul 30, 2019 · 3 comments

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 30, 2019

Description

Theme change doesn't update URL bar until mouse over

Steps to Reproduce

  1. Upgrade to 0.68.113
  2. Change theme in settings
  3. URL bar theme changes only when you mouse over or tab focus is changed

Actual result:

urltheme

Expected result:

Should automatically change when theme is changed

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Sort of different issue Theme change only updates webUI and not URL bar #5464
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@simonhong
Copy link
Member

simonhong commented Jul 30, 2019

@srirambv I think this only happens with GTK+ theme. This is regression after C76 update.
With Classic theme, this would not be reproduced.
This can be fixed by brave/brave-core#2905 that already in 0.69.x
I think uplifting brave/brave-core#2905 to beta would be good?

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 7, 2019
@simonhong simonhong added this to the 0.69.x - Beta milestone Aug 27, 2019
@simonhong
Copy link
Member

Closed because this was fixed by brave/brave-core#2905

@LaurenWags
Copy link
Member

LaurenWags commented Aug 29, 2019

Verified passed with

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified STR from the description.

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified STR from the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants