Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux dark mode is still light #965

Closed
petemill opened this issue Sep 5, 2018 · 6 comments · Fixed by brave/brave-core#2905
Closed

Linux dark mode is still light #965

petemill opened this issue Sep 5, 2018 · 6 comments · Fixed by brave/brave-core#2905
Assignees
@petemill @simonhong
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@petemill
Copy link
Member

petemill commented Sep 5, 2018

Linux color properties likely come from a theme related to a native mode.

image
@petemill petemill added this to the Releasable builds 0.55.x milestone Sep 5, 2018
@petemill petemill self-assigned this Sep 5, 2018
@bbondy
Copy link
Member

bbondy commented Sep 5, 2018

cc @simonhong

@simonhong
Copy link
Member

Hmm, it's strange. color options work well on my local machine(ubuntu 17.10, gnome-shell).
@petemill Can you check BraveThemeService::GetDefaultColor() is called?

@maikelmclauflin
Copy link

maikelmclauflin commented Sep 6, 2018 •
edited
Loading

same thing happens on mac. I found that if after changing the brave colors dropdown, you toggle the show home button the color seems to update.

@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.x Backlog Sep 9, 2018
@srirambv srirambv added feature/user-interface All UI related and removed feature/ui labels Sep 18, 2018
@simonhong simonhong self-assigned this Nov 13, 2018
@AlexeyBarabash
Copy link
Contributor

I can also see it on my Linux Ubuntu 16.04 LTS.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@simonhong simonhong mentioned this issue Apr 30, 2019
Closed
@btlechowski
Copy link

Still reproducible on

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

image

#3894 needs to be re-verified when this issue is fixed.

@LaurenWags LaurenWags mentioned this issue May 8, 2019
Closed
@simonhong simonhong mentioned this issue Jul 15, 2019
Merged
32 tasks
@bsclifton
Copy link
Member

Dupe of #5098

@bsclifton bsclifton added closed/duplicate Issue has already been reported and removed OS/Linux bug labels Jul 17, 2019
@bsclifton bsclifton removed the feature/user-interface All UI related label Jul 17, 2019
@bsclifton bsclifton added this to the Dupe / Invalid / Not actionable milestone Jul 17, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

@simonhong simonhong

Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring brave theme related modules brave/brave-core
9 participants
@petemill @bbondy @bsclifton @maikelmclauflin @rebron @simonhong @srirambv @AlexeyBarabash @btlechowski