-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most webui buttons are hidden in new dark theme with c74 #3894
Labels
design
A design change, especially one which needs input from the design team
feature/user-interface
All UI related
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
regression
release-notes/exclude
Milestone
Comments
bsclifton
added
design
A design change, especially one which needs input from the design team
feature/user-interface
All UI related
labels
Mar 26, 2019
rebron
added
the
priority/P2
A bad problem. We might uplift this to the next planned release.
label
Mar 29, 2019
@petemill Can you take a look? |
Yes I’ll fix it when c74 lands again |
This also affects normal buttons, changing title / description to reflect that |
petemill
changed the title
'Cancel' button in main settings is hidden in dark theme
Most webui buttons are hidden in new dark theme
Apr 1, 2019
petemill
changed the title
Most webui buttons are hidden in new dark theme
Most webui buttons are hidden in new dark theme with c74
Apr 1, 2019
19 tasks
Resolved when C74 was merged to master with #3931 😄 |
This was referenced Apr 2, 2019
This was referenced Apr 2, 2019
This was referenced Apr 2, 2019
Verified passed with
Verification PASSED on
Verification passed on
Verification passed on
This issue is blocked on Linux, because of #965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
A design change, especially one which needs input from the design team
feature/user-interface
All UI related
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
regression
release-notes/exclude
Description
When in main settings in dark mode, regular (not 'action') buttons (e.g. the 'cancel' button within modal, the 'default browser' button, etc) cannot be seen.
Test plan / Steps to Reproduce
Actual result:
'cancel' button is hidden
Expected result:
'cancel' button should be easily seen
Reproduces how often:
easily
Brave version (brave://version info)
0.64.x (c74)
Reproducible on current release:
Website problems only:
Additional Information
cc @petemill
The text was updated successfully, but these errors were encountered: