Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly tip notification is not translated #4236

Closed
btlechowski opened this issue Apr 25, 2019 · 11 comments
Closed

Monthly tip notification is not translated #4236

btlechowski opened this issue Apr 25, 2019 · 11 comments

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Clean install
  2. Run Brave with flag: --rewards=staging=true,reconcile-interval=5
  3. Change Brave locale to Polish
  4. Relaunch Brave with flag: --rewards=staging=true,reconcile-interval=5
  5. Enable Rewards and claim grant
  6. Monthly tip duckduckgo.com
  7. Disable auto-contribute in brave://rewards
  8. Wait for Monthly tip reconciliation

Actual result:

Monthly tip notification is not translated
image

Expected result:

Monthly tip notification is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

cc @brave/legacy_qa @NejcZdovc @ryanml

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 26, 2019
@rebron
Copy link
Collaborator

rebron commented Apr 26, 2019

@btlechowski can you recheck with @mkarolin localization pull?

@mkarolin
Copy link
Contributor

@btlechowski, @rebron I don't see any new Polish translations in the localization I pulled.

@bbondy
Copy link
Member

bbondy commented Apr 27, 2019

@NejcZdovc
A @mkarolin says it's still not fixed after the localization update, could you check why?

@NejcZdovc NejcZdovc self-assigned this Apr 27, 2019
@NejcZdovc
Copy link
Contributor

this strings are quite new, so they are just not translated/added in transifex. Will close it as this will be fixed when we get new update from transifex

@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone May 1, 2019
@NejcZdovc NejcZdovc added closed/not-actionable and removed QA/Test-Plan-Specified QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. labels May 1, 2019
@kjozwiak kjozwiak modified the milestones: Dupe / Invalid / Not actionable, 0.64.x - Beta May 2, 2019
@kjozwiak
Copy link
Member

kjozwiak commented May 2, 2019

Moved this back into 0.64.x as brave/brave-core#2343 has been uplifted. This will need to be verified.

@NejcZdovc
Copy link
Contributor

@kjozwiak brave/brave-core#2343 doesn't fix this problem. That PR doesn't have this new strings

@kjozwiak kjozwiak removed this from the 0.64.x - Beta milestone May 2, 2019
@kjozwiak
Copy link
Member

kjozwiak commented May 2, 2019

Moved it out of 0.64.x but we shouldn't close the issue just because it's not actionable. This still needs to be checked and verified once we add the new strings.

We'll need to wait till we get the new strings so we can make sure this also has been fixed. Also related to #4212.

@NejcZdovc
Copy link
Contributor

I am moving then this to general project

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 7, 2019
@rebron
Copy link
Collaborator

rebron commented May 31, 2019

@btlechowski Can you take a look at this one? I think we have updated strings now.

@btlechowski
Copy link
Author

btlechowski commented Jun 12, 2019

Not reproducible on

Brave 0.66.88 Chromium: 75.0.3770.87 (Official Build) beta (64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Windows 7 Service Pack 1 (Build 7601.24465)

image

Also not reproducible on: Czech, German, Dutch, Danish, Finnish, Italian, Japanese, Korean, Norwegian, Russian

@kjozwiak
Copy link
Member

Awesome, thanks for the recheck @btlechowski 👍

@kjozwiak kjozwiak added closed/invalid and removed QA/Test-Plan-Specified QA/Yes feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants