-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Microphone icon on Google showing again #42416
Comments
cc: @ryanbr |
Was reverted a while ago, brave/brave-core@d201ff6 brave/brave-core#4371 I honestly forgot about this. If we need to re-hide the mic, it'll be easier to just use a cosmetic.
cc: @ShivanKaul |
Yeah, if the hide is in brave-specific list it shouldn't break any tests like what happened in brave/brave-core#4371. |
@Brave-Matt Is this working better? does it work well on all the platforms? |
Checked IOS, Android and Desktop now fixed. |
We can revisit this later, basically Android google voice search is fine, no need to hide it. IOS and Desktop doesn't work. |
Description
The microphone icon on Google.com is showing again after being hidden previously via:
brave/brave-core#3978
This can be confusing for users who are under the impression that they can use this feature.
Steps to reproduce
Actual result
Icon appears
Expected result
Icon should remain hidden
Reproduces how often
Easily reproduced
Brave version (brave://version info)
v.173.89
Channel information
Reproducibility
Miscellaneous information
Related: #2690
The text was updated successfully, but these errors were encountered: