Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Microphone icon on Google showing again #42416

Open
3 of 6 tasks
Brave-Matt opened this issue Nov 20, 2024 · 6 comments
Open
3 of 6 tasks

Regression: Microphone icon on Google showing again #42416

Brave-Matt opened this issue Nov 20, 2024 · 6 comments
Assignees
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy regression

Comments

@Brave-Matt
Copy link

Brave-Matt commented Nov 20, 2024

Description

The microphone icon on Google.com is showing again after being hidden previously via:
brave/brave-core#3978

Image

This can be confusing for users who are under the impression that they can use this feature.

Steps to reproduce

  1. Visit Google.com
  2. Observe microphone icon in search field

Actual result

Icon appears

Expected result

Icon should remain hidden

Reproduces how often

Easily reproduced

Brave version (brave://version info)

v.173.89

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Related: #2690

@rebron
Copy link
Collaborator

rebron commented Nov 22, 2024

cc: @ryanbr

@ryanbr
Copy link

ryanbr commented Nov 23, 2024

Was reverted a while ago, brave/brave-core@d201ff6 brave/brave-core#4371 I honestly forgot about this.

If we need to re-hide the mic, it'll be easier to just use a cosmetic.

www.google.*##[aria-label="Search by voice"] (limit to www and not other google domains like gmail)

cc: @ShivanKaul

@ShivanKaul
Copy link
Collaborator

Yeah, if the hide is in brave-specific list it shouldn't break any tests like what happened in brave/brave-core#4371.
cc @iefremov and @bsclifton, this would (re-)add a cosmetic filtering fix while we're figuring out #3725

@ryanbr
Copy link

ryanbr commented Nov 27, 2024

@Brave-Matt Is this working better? does it work well on all the platforms?

@ryanbr
Copy link

ryanbr commented Nov 30, 2024

Checked IOS, Android and Desktop now fixed.

@ryanbr
Copy link

ryanbr commented Dec 1, 2024

We can revisit this later, basically Android google voice search is fine, no need to hide it. IOS and Desktop doesn't work.
Android and desktop share the same filters, so no way seperate the rules currently, lets revert this for the sake of compatibility on Android.

ref: https://old.reddit.com/r/brave_browser/comments/1h2pvin/google_voice_search_button_not_showing_in_brave/

@ShivanKaul ShivanKaul added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy regression
Projects
None yet
Development

No branches or pull requests

4 participants