Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leo AI Full-Page (chrome://leo-ai) should prompt for PWA install #42701

Closed
2 of 6 tasks
petemill opened this issue Dec 5, 2024 · 4 comments · Fixed by brave/brave-core#27025
Closed
2 of 6 tasks

Leo AI Full-Page (chrome://leo-ai) should prompt for PWA install #42701

petemill opened this issue Dec 5, 2024 · 4 comments · Fixed by brave/brave-core#27025
Assignees
@petemill
Labels
browser-ai OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.75.x - Release

Comments

@petemill
Copy link
Member

petemill commented Dec 5, 2024 •
edited
Loading

Description

Leo AI Full-Page (chrome://leo-ai) should prompt for PWA install

Steps to reproduce

  1. Visit chrome://leo-ai

Expected result

Observe "install" button on toolbar

Image

Actual result

"install" button not showing

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

1.75, 1.74

Android device

  • Brand/model:
  • Android version:

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Also "create shortcut" app menu item is disabled, but should be enabled. All of this works on brave://password-manager
@petemill petemill added OS/Android Fixes related to Android browser functionality OS/Desktop QA/Yes labels Dec 5, 2024
@petemill petemill mentioned this issue Dec 16, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 17, 2024
@hffvld
Copy link
Contributor

hffvld commented Dec 19, 2024

Removing label OS/Android based on the conversation with @petemill. A separate issue needs to be created for the Android platform.

@hffvld hffvld removed the OS/Android Fixes related to Android browser functionality label Dec 19, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.75.114 Chromium: 132.0.6834.46 (Official Build) nightly (64-bit)
Revision 2c7caf1265beb933db9dbe9db2500da09cb93620
OS Windows 11 Version 23H2 (Build 22631.4460)
  • Verified steps from issue description
  • Verified Leo AI Full page shows prompt for installing PWA
  • Verified installing PWA shows shortcut on Desktop
  • Encountered #43006 & #43007
42701.mp4

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.75.112 Chromium: 132.0.6834.46 (Official Build) nightly (64-bit)
Revision f1de7e60955b06e067a605adca9d6a87d6142baf
OS Linux
  • Verified steps from issue description
  • Verified Leo AI Full page shows prompt for installing PWA
  • Verified installing PWA shows shortcut on Desktop
  • Encountered #43006 & #43007
42701.mp4

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.75.112 Chromium: 132.0.6834.46 (Official Build) nightly (arm64)
Revision f1de7e60955b06e067a605adca9d6a87d6142baf
OS macOS Version 15.2 (Build 24C101)
  • Verified steps from issue description
  • Verified Leo AI Full page shows prompt for installing PWA
  • Verified installing PWA shows shortcut on Desktop
  • Encountered #43006, #43007 & #43008
42701.mp4

@LaurenWags LaurenWags mentioned this issue Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
browser-ai OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.75.x - Release
Development

Successfully merging a pull request may close this issue.

Leo AI becomes an installable PWA brave/brave-core
6 participants
@petemill @fallaciousreasoning @srirambv @LaurenWags @brave-builds @hffvld