Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while building 0.65.x #4343

Closed
bsclifton opened this issue May 8, 2019 · 0 comments · Fixed by brave/brave-core#2384
Closed

Error while building 0.65.x #4343

bsclifton opened this issue May 8, 2019 · 0 comments · Fixed by brave/brave-core#2384

Comments

@bsclifton
Copy link
Member

Description

Can be seen on Windows when building on 0.65.x

Error looks like this:

06:36:21  In file included from C:\jenkins\workspace\os_theme_with_brave_theme_0.65.x\src\brave\chromium_src\ui\base\webui\web_ui_util.cc:15:
06:36:21  ../../brave/chromium_src\chrome/grit/generated_resources.h(2,10):  fatal error: '../gen/chrome/grit/generated_resources.h' file not found
06:36:21  #include "../gen/chrome/grit/generated_resources.h"
06:36:21           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
06:36:21  1 error generated.

Steps to Reproduce

  1. On Windows, clone brave-browser
  2. Checkout 0.65.x branch
  3. Update brave-core branch to be pr2219_align_windows_os_theme_with_brave_theme_0.65.x
  4. Run npm run init and npm run build -- Release

Actual result:

Error occurs during compilation. For more info, see https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr2219_align_windows_os_theme_with_brave_theme_0.65.x/1/execution/node/222/log/

Expected result:

No error

Reproduces how often:

Seems to reproduce in 0.65.x on CI... but doesn't reproduce on master (even though it's an issue there too)

Brave version (brave://version info)

@bsclifton bsclifton added this to the 0.67.x - Nightly milestone May 8, 2019
bsclifton added a commit to brave/brave-core that referenced this issue May 13, 2019
Add strings for NavigationBar on relevant WebUI data sources directly

---

Uplift of #2384

Fixes brave/brave-browser#4343
bsclifton added a commit to brave/brave-core that referenced this issue May 13, 2019
Add strings for NavigationBar on relevant WebUI data sources directly

---

Uplift of #2384

Fixes brave/brave-browser#4343
bsclifton added a commit to brave/brave-core that referenced this issue May 14, 2019
Add strings for NavigationBar on relevant WebUI data sources directly

---

Uplift of #2384

Fixes brave/brave-browser#4343
bsclifton added a commit to brave/brave-core that referenced this issue May 14, 2019
Add strings for NavigationBar on relevant WebUI data sources directly

---

Uplift of #2384

Fixes brave/brave-browser#4343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants