-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error while building 0.65.x #4343
Comments
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
May 13, 2019
Add strings for NavigationBar on relevant WebUI data sources directly --- Uplift of #2384 Fixes brave/brave-browser#4343
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
May 13, 2019
Add strings for NavigationBar on relevant WebUI data sources directly --- Uplift of #2384 Fixes brave/brave-browser#4343
This was referenced May 13, 2019
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
May 14, 2019
Add strings for NavigationBar on relevant WebUI data sources directly --- Uplift of #2384 Fixes brave/brave-browser#4343
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
May 14, 2019
Add strings for NavigationBar on relevant WebUI data sources directly --- Uplift of #2384 Fixes brave/brave-browser#4343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Can be seen on Windows when building on 0.65.x
Error looks like this:
Steps to Reproduce
brave-browser
0.65.x
branchbrave-core
branch to bepr2219_align_windows_os_theme_with_brave_theme_0.65.x
npm run init
andnpm run build -- Release
Actual result:
Error occurs during compilation. For more info, see https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr2219_align_windows_os_theme_with_brave_theme_0.65.x/1/execution/node/222/log/
Expected result:
No error
Reproduces how often:
Seems to reproduce in 0.65.x on CI... but doesn't reproduce on master (even though it's an issue there too)
Brave version (brave://version info)
The text was updated successfully, but these errors were encountered: