Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweet is missing hashtag #4555

Closed
mandar-brave opened this issue May 23, 2019 · 4 comments · Fixed by brave/brave-core#2495
Closed

Tweet is missing hashtag #4555

mandar-brave opened this issue May 23, 2019 · 4 comments · Fixed by brave/brave-core#2495

Comments

@mandar-brave
Copy link

The current tweet is missing hashtag "#TipWithBrave" is missing from the tweet-string. Please add.

cc @emerick @NejcZdovc @bradleyrichter

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels May 23, 2019
@mandar-brave
Copy link
Author

Lets fix ahead of the developer builds. Thank you!

@emerick
Copy link
Contributor

emerick commented May 24, 2019

@mandar-brave Can we get that added to the spec? I don't think I ever saw it mentioned, but could be I just missed it!

@emerick emerick self-assigned this May 24, 2019
@mandar-brave
Copy link
Author

Done!

@LaurenWags
Copy link
Member

LaurenWags commented Jul 11, 2019

Verified passed with

Brave 0.67.107 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Tweet generated when tipping a specific tweet using inline tip button:
Screen Shot 2019-07-11 at 11 32 01 AM

Tweet generated when tipping a YT video from panel (unable to check YT channel due to #5217):
Screen Shot 2019-07-11 at 1 06 44 PM

Tweet generated when tipping a Twitch channel from panel:
Screen Shot 2019-07-11 at 1 07 12 PM

Tweet generated when tipping a Twitch video from panel:
Screen Shot 2019-07-11 at 1 07 33 PM

Tweet generated when tipping a regular site from panel:
Screen Shot 2019-07-11 at 1 08 02 PM

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the test plan from Add #TipWithBrave hashtag to twip brave-core#2495

  • Verified that the hashtag appears in the posted tweet ( Tip from twitter feed)
    image

  • Verified that the hashtag appears in the posted tweet ( Tip from Rewards panel)
    image

  • Verified that the hashtag appears when tipping twitch video from panel.
    image

  • Verified that the hashtag appears when tipping YT video from panel.
    image

  • Verified that the hashtag appears when tipping general site from panel.
    image

  • Verified that the hashtag appears when tipping embedded video from the panel.
    image

  • Verified the hashtag appear for both verified and non - verified pubs (Twitch, YT, General sites, Embedded videos, Twitter site)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS
  • Verified the test plan from Add #TipWithBrave hashtag to twip brave-core#2495

  • Verified that the hashtag appears in the posted tweet ( Tip from twitter feed)
    image

  • Verified that the hashtag appears in the posted tweet ( Tip from Rewards panel)
    image

  • Verified that the hashtag appears when tipping twitch video from panel.
    image

  • Verified that the hashtag appears when tipping YT video from panel.
    image

  • Verified that the hashtag appears when tipping general site from panel.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants