Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blocking a script should take effect immediately #4572

Closed
cezaraugusto opened this issue May 23, 2019 · 2 comments · Fixed by brave/brave-core#2485
Closed

blocking a script should take effect immediately #4572

cezaraugusto opened this issue May 23, 2019 · 2 comments · Fixed by brave/brave-core#2485
Assignees
@cezaraugusto
Labels
feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.68.x - Release

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented May 23, 2019 •
edited
Loading

Task split of #2996

Test plan

  1. Go to https://brianbondy.com
  2. Block all scripts
  3. Assert that page is blank
  4. Go to scripts detail view
  5. Allow the script
  6. Script should show "allowed once" remaining under "blocked" list
  7. Go back, blur, or close shields
  8. Open scripts detail view
  9. Script should be under "allowed" list

After blocking a script, action should take effect immediately and tab should refresh reflecting the new state.

A new intermediary state "blocked once"/"allowed once" will be created to reflect user interaction:

Screen Shot 2019-05-23 at 17 25 26
@cezaraugusto cezaraugusto added feature/shields The overall Shields feature in Brave. feature/shields/!scripts Blocking JavaScript with Shields labels May 23, 2019
@cezaraugusto cezaraugusto added this to the 0.67.x - Nightly milestone May 23, 2019
@cezaraugusto cezaraugusto self-assigned this May 23, 2019
@cezaraugusto cezaraugusto mentioned this issue May 23, 2019
Merged
6 tasks
cezaraugusto added a commit to brave/brave-core that referenced this issue May 27, 2019
@cezaraugusto
add new noScript interface
2cb0d16 
-
* scripts now show intermediary state "allowed once" and "blocked once"
* lists with zero items are now hidden
* add ability to see grouped scripts

fix brave/brave-browser#4572
fix brave/brave-browser#4570
fix brave/brave-browser#4567
address brave/brave-browser#2996
@kjozwiak kjozwiak removed this from the 0.67.x - Dev milestone Jun 3, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2019

Removed 0.67.x - Dev as this issue hasn't been closed/completed and still needs to land in nightly. @cezaraugusto once the PR for this issue lands in nightly, let's add all needed labels and move the issue into the appropriate milestone at that point 👍

bsclifton pushed a commit to brave/brave-core that referenced this issue Jun 5, 2019
@cezaraugusto @bsclifton
add new noScript interface
86d5b33 
-
* scripts now show intermediary state "allowed once" and "blocked once"
* lists with zero items are now hidden
* add ability to see grouped scripts

fix brave/brave-browser#4572
fix brave/brave-browser#4570
fix brave/brave-browser#4567
address brave/brave-browser#2996
@cezaraugusto cezaraugusto added this to the 0.68.x - Nightly milestone Jun 7, 2019
@cezaraugusto cezaraugusto added QA/Yes QA/Test-Plan-Specified priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 7, 2019
@btlechowski
Copy link

btlechowski commented Jul 31, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Used test plan from brave/brave-core#2485
Used test plan from the description.

Verified that it is possible to Allow script once in main view
image

Verified that it is possible to Allow script once in detailed view
image

Verified that after closing and opening the same page, the blocked scripts are reset to initial state and that Allow script once is shown.
Verified that after closing the browser, the blocked scripts are reset to initial state and that Allow script once is shown.

Verification passed on

Brave 0.68.115 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verified passed with

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

This was referenced Aug 2, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

Update NoScript interface brave/brave-core
5 participants
@kjozwiak @cezaraugusto @LaurenWags @btlechowski @GeetaSarvadnya