-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
component updater should not be tied to extensions or brave_shields #4577
Comments
Test Plan:
|
Verification passed on
Used test plan from #4577 (comment) Verification passed with
Used test plan from #4577 (comment) Verification PASSED on
|
@bridiver as @btlechowski noted, |
this change shouldn't affect which sites are upgraded, only whether upgrades work or not and http://www.http2demo.io/ doesn't get upgraded for me on release either. Maybe it isn't in the httpse list anymore? cc @diracdeltas |
according to https://github.com/EFForg/https-everywhere/search?q=http2demo.io&unscoped_q=http2demo.io and https://atlas.eff.org//?http2demo.io, http2demo.io isn't on the current ruleset list. i usually use https://https-everywhere.badssl.com/ for testing. |
The brave component updater is coupled to extensions and brave shields which causes problems for android
The text was updated successfully, but these errors were encountered: