Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component updater should not be tied to extensions or brave_shields #4577

Closed
bridiver opened this issue May 23, 2019 · 5 comments
Closed

component updater should not be tied to extensions or brave_shields #4577

bridiver opened this issue May 23, 2019 · 5 comments

Comments

@bridiver
Copy link
Contributor

bridiver commented May 23, 2019

The brave component updater is coupled to extensions and brave shields which causes problems for android

@bridiver bridiver self-assigned this May 23, 2019
@bridiver
Copy link
Contributor Author

bridiver commented May 23, 2019

Test Plan:

  1. Verify that ad block is working - (slashdot.org or other site with shields on/off)
  2. Verify https everywhere is working - (http://www.http2demo.io/ should be upgraded)
  3. Verify autoplay whitelist is working - (youtube.com should autoplay)
  4. Verify referrer whitelist is working - (www.facebook.com should load correctly with all css/images)
  5. Verify extension whitelist is working - (install 1Password)

@btlechowski
Copy link

btlechowski commented Jul 23, 2019

Verification passed on

Brave 0.67.115 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Used test plan from #4577 (comment)
Https upgrade was tested with http://https-everywhere.badssl.com/. http://www.http2demo.io/ doesn't seem to work correctly even over https.

Verification passed with

Brave 0.67.112 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Used test plan from #4577 (comment)
HTTPSE tested as per #4577 (comment)

Verification PASSED on Win 10 x64 using the following build:

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1809 (Build 17763.615)

@LaurenWags
Copy link
Member

@bridiver as @btlechowski noted, http://www.http2demo.io/ isn't working - site is not being upgraded to https. however, http://https-everywhere.badssl.com/ is though. let us know if this is acceptable, thanks.

@bridiver
Copy link
Contributor Author

bridiver commented Jul 24, 2019

this change shouldn't affect which sites are upgraded, only whether upgrades work or not and http://www.http2demo.io/ doesn't get upgraded for me on release either. Maybe it isn't in the httpse list anymore? cc @diracdeltas

@diracdeltas
Copy link
Member

according to https://github.com/EFForg/https-everywhere/search?q=http2demo.io&unscoped_q=http2demo.io and https://atlas.eff.org//?http2demo.io, http2demo.io isn't on the current ruleset list. i usually use https://https-everywhere.badssl.com/ for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment