-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect tip banner text for tipping an image/video #4583
Comments
@NejcZdovc to confirm, even if the twitter user you're trying to tip has a custom banner, in this case you still want it to show the default text? Here's what I'm doing:
Just want to confirm we are expecting different body text in the two places when tipping an image/gif. |
title is different yes if you tip from inline tip or from panel tip |
ok, thanks! |
Verification passed on
Tip from BR panel: Verification passed on
|
Description
Per spec, when tipping a tweet without any extractable text, you should see something like the image below, however, that's not what's occurring.
Steps to Reproduce
Actual result:
Expected result:
Expecting to see text that said 'Tip @bravelaurenwags for their tweet!' instead of empty tweet box.
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @brave/legacy_qa @mandar-brave @alexwykoff @jenn-rhim
https://twitter.com/bravelaurenwags/status/1131664248856354816 - there's also a reply tweet on this thread which contains a gif that acts the same as the image.
The text was updated successfully, but these errors were encountered: