Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect tip banner text for tipping an image/video #4583

Closed
LaurenWags opened this issue May 23, 2019 · 5 comments · Fixed by brave/brave-core#2505
Closed

incorrect tip banner text for tipping an image/video #4583

LaurenWags opened this issue May 23, 2019 · 5 comments · Fixed by brave/brave-core#2505

Comments

@LaurenWags
Copy link
Member

LaurenWags commented May 23, 2019

Description

Per spec, when tipping a tweet without any extractable text, you should see something like the image below, however, that's not what's occurring.
Screen Shot 2019-05-23 at 4 54 02 PM

Steps to Reproduce

  1. Locate a tweet with just an image (can use this one if needed, should work for both staging and prod: https://twitter.com/bravelaurenwags/status/1131664248856354816)
  2. Click on Tip button

Actual result:

Screen Shot 2019-05-23 at 4 52 44 PM

Expected result:

Expecting to see text that said 'Tip @bravelaurenwags for their tweet!' instead of empty tweet box.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.67.55 Chromium: 75.0.3770.38 (Official Build) nightly(64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @mandar-brave @alexwykoff @jenn-rhim

https://twitter.com/bravelaurenwags/status/1131664248856354816 - there's also a reply tweet on this thread which contains a gif that acts the same as the image.

@NejcZdovc
Copy link
Contributor

This is what we it would look like now:

image

@LaurenWags
Copy link
Member Author

@NejcZdovc to confirm, even if the twitter user you're trying to tip has a custom banner, in this case you still want it to show the default text? Here's what I'm doing:
(using staging)

  1. Navigate to https://twitter.com/bravelaurenwags/status/1131664248856354816
  2. Click on in-line tip button
  3. See this banner - note, it shows default text in the body (text from Update default tipping banner text #4616)
    Screen Shot 2019-07-10 at 6 14 00 PM
  4. Close banner, navigate to just twitter.com/bravelaurenwags
  5. Click on panel, click on Send a Tip
  6. Here, the entire custom banner is shown, even custom text in the body of the banner:
    Screen Shot 2019-07-10 at 6 14 17 PM

Just want to confirm we are expecting different body text in the two places when tipping an image/gif.

@NejcZdovc
Copy link
Contributor

title is different yes if you tip from inline tip or from panel tip

@LaurenWags
Copy link
Member Author

ok, thanks!

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 15, 2019

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

In-line tip:
image

Tip from BR panel:

image

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment