Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Verified Twitter publishers should display "verified" icon/branding per-tweet #4649

Closed
Brave-Matt opened this issue May 30, 2019 · 6 comments
Labels
feature/rewards needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion

Comments

@Brave-Matt
Copy link

Brave-Matt commented May 30, 2019

Description

Currently, verified Twitter publishers display "verified" icon on their twitter page:
image

Verified Twitter publishers should display the verified icon per-tweet, so users can tell they're verified from their home page/feed:

image

@mandar-brave @petemill @rebron

Miscellaneous Information:

There was a design discussion surrounding visibility and "blending" too heavily into twitter UI -- this approach would be simple and avoids these concerns:
https://bravesoftware.slack.com/archives/C07HD31EZ/p1557279876080500

@mandar-brave mandar-brave added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Aug 1, 2019
@NejcZdovc NejcZdovc removed the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Aug 2, 2019
@RetroCraft
Copy link

This should also be generalized to Reddit and other future integrations.

@Brave-Matt
Copy link
Author

A few +1s from Reddit:
https://www.reddit.com/r/brave_browser/comments/cn1pvu/suggestion_hide_the_tip_button_on_social_media/

@Brave-Matt
Copy link
Author

+1 https://www.reddit.com/r/brave_browser/comments/cv21uy/you_should_be_able_to_see_who_has_a_linked/

@Brave-Matt
Copy link
Author

@zenparsing zenparsing added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 20, 2021
@zenparsing zenparsing added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Oct 20, 2021
@zenparsing
Copy link

Note that we do not want to query for the publisher status until after the user has opted-in to rewards.

@Miyayes
Copy link
Collaborator

Miyayes commented Mar 4, 2023

Last time we discussed this, we reasoned that it would not be feasible. We would have to hit our API for every single creator, and on a single twitter timeline, that would be many creators. This was more practical back in the day when the browser just downloaded the full set of creators.

@Miyayes Miyayes closed this as completed Mar 4, 2023
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion
Projects
None yet
Development

No branches or pull requests

6 participants