Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a verified logo in the tip banner #5517

Closed
mandar-brave opened this issue Aug 2, 2019 · 5 comments · Fixed by brave/brave-core#3283
Closed

Add a verified logo in the tip banner #5517

mandar-brave opened this issue Aug 2, 2019 · 5 comments · Fixed by brave/brave-core#3283

Comments

@mandar-brave
Copy link

For inline tipping, there is no way for a tipper who clicks on the logo to know if the receiver is verified (or not). And very few folks read the disclaimer.

Add the verified logo to the tip banner so add some visual symbol of verification -- the tip panel is working great if a user starts there.

Illustration:
image

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Aug 2, 2019
@mandar-brave
Copy link
Author

@NejcZdovc

@kjozwiak kjozwiak added the QA/Yes label Aug 2, 2019
@Brave-Matt
Copy link

@mandar-brave,
Is this method being chosen over the initial method proposed in #4649 ( no offense taken :) ) -- or maybe in tandem? I ask because this particular methodology seems "clunky" UX wise.

For example, a user scrolling through their Twitter feed wants to Tip another verified user. If the verified logo appears in the tip banner, without #4649 in place as well, the user is required to click the Tip and load the banner to learn whether or not the user they want to tip is verified.

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Aug 2, 2019

@Brave-Matt problem with #4649 is that would mean that we would need to fetch data for every publisher that is displayed on the page and could mean some lagging while scrolling. This issue is first step that we will do (to have the same UI) and then we will investigate how we can do #4649 performance efficient

@NejcZdovc NejcZdovc self-assigned this Aug 2, 2019
@mandar-brave
Copy link
Author

@Brave-Matt #4659 is what we would prefer; but seems like a lot of heavy weight lifting - a compromise but allows for some symbolism of verification!

@NejcZdovc NejcZdovc added this to the 0.69.x - Beta milestone Aug 28, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 30, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 1, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 1, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Sep 4, 2019

Verified passed with

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Verified test plan from Adds checkmark to the banner brave-core#3283
  • Ensured that connected and verified publishers show the verified icon on the tip banner.
  • Ensured that unverified publishers do not show the verified icon on the tip banner.
  • Checked the following types of verified publishers: regular sites, YouTube, Twitter, Twitch, Reddit, Vimeo, Github.
  • Ensured verified icon displays if publisher has custom banner images/text
  • Ensured verified icon displays if publisher does not have custom banner.

Verified publisher tip banner on Staging:
Screen Shot 2019-09-04 at 1 58 20 PM

Connected, not verified publisher tip banner on Staging:
Screen Shot 2019-09-04 at 1 58 52 PM

Unverified publisher tip banner on Staging:
Screen Shot 2019-09-04 at 1 59 09 PM

Verified publisher tip banner on Prod:
Screen Shot 2019-09-04 at 2 14 26 PM

Connected, not verified publisher tip banner on Prod:
Screen Shot 2019-09-04 at 2 15 05 PM

Unverified publisher tip banner on Prod:
Screen Shot 2019-09-04 at 2 15 23 PM

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified test plan from Adds checkmark to the banner brave-core#3283
  • Ensured that connected and verified publishers show the verified icon on the tip banner.
  • Ensured that unverified publishers do not show the verified icon on the tip banner.
  • Checked the following types of verified publishers: regular sites, YouTube, Twitter, Twitch, Reddit, Vimeo, Github.
  • Ensured verified icon displays if publisher has custom banner images/text
  • Ensured verified icon displays if publisher does not have custom banner.

Verified publisher tip banner on Staging:
image

Connected, not verified publisher tip banner on Staging:
image

Unverified publisher tip banner on Staging:
image

Verified publisher tip banner on Prod:
image

Connected, not verified publisher tip banner on Prod:
image

Unverified publisher tip banner on Prod:
image

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified test plan from Adds checkmark to the banner brave-core#3283
  • Ensured that connected and verified publishers show the verified icon on the tip banner.
  • Ensured that unverified publishers do not show the verified icon on the tip banner.
  • Checked the following types of verified publishers: regular sites, YouTube, Twitter, Twitch, Reddit, Vimeo, Github.
  • Ensured verified icon displays if publisher has custom banner images/text
  • Ensured verified icon displays if publisher does not have custom banner.

Verified publisher tip banner on Staging:
image

Connected, not verified publisher tip banner on Staging:

image

Unverified publisher tip banner on Staging:

image

Verified publisher tip banner on Prod:
image

image

Connected, not verified publisher tip banner on Prod:
image

Unverified publisher tip banner on Prod:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants