Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User wallet: Contributions #4775

Closed
mandar-brave opened this issue Jun 10, 2019 · 2 comments · Fixed by brave/brave-core#2696
Closed

User wallet: Contributions #4775

mandar-brave opened this issue Jun 10, 2019 · 2 comments · Fixed by brave/brave-core#2696

Comments

@mandar-brave
Copy link

Once connected to the Uphold wallet (Verified or Unverified), if there is a balance in the BAT Card for contributions, the transactions will go through.

User wallet -> a/c will now need authorized user wallet token to sign transaction from user wallet to settlement wallet.

User wallet -> tips will now need authorized user wallet token to sign transaction from user wallet to publisher wallet.

User wallet -> tips will also have separate protocol change tracked in another issue.

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 10, 2019
@mandar-brave
Copy link
Author

@evq FYI for tracking changes.
@alexwykoff

@mandar-brave mandar-brave added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 24, 2019
@NejcZdovc NejcZdovc self-assigned this Jul 8, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Nightly milestone Jul 8, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Sep 4, 2019

Verified passed with

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants