-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uphold wallet #2696
Merged
Merged
Uphold wallet #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
uphold-wallet
branch
2 times, most recently
from
June 18, 2019 12:01
94a429a
to
d04318b
Compare
NejcZdovc
force-pushed
the
uphold-wallet
branch
7 times, most recently
from
June 20, 2019 15:29
f2862b7
to
6560a12
Compare
32 tasks
NejcZdovc
force-pushed
the
uphold-wallet
branch
4 times, most recently
from
June 23, 2019 13:11
f11ed94
to
abf293d
Compare
NejcZdovc
added
CI/skip-android
Do not run CI builds for Android
CI/skip-ios
Do not run CI builds for iOS
CI/skip-linux
labels
Jun 24, 2019
NejcZdovc
force-pushed
the
uphold-wallet
branch
6 times, most recently
from
June 25, 2019 18:23
4df18e8
to
d307b59
Compare
tmancey
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
evq
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving / merging as since last code owner approval this has only undergone a rebase where there was a single conflict in a mojo file
This was referenced Aug 29, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#5005
Resolves brave/brave-browser#5004
Resolves brave/brave-browser#4774
Resolves brave/brave-browser#4776
Resolves brave/brave-browser#4775
Resolves brave/brave-browser#4779
UI PR: brave/brave-ui#497
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.