Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uphold wallet #2696

Merged
merged 22 commits into from
Jul 23, 2019
Merged

Uphold wallet #2696

merged 22 commits into from
Jul 23, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 14, 2019

Resolves brave/brave-browser#5005
Resolves brave/brave-browser#5004
Resolves brave/brave-browser#4774
Resolves brave/brave-browser#4776
Resolves brave/brave-browser#4775
Resolves brave/brave-browser#4779

UI PR: brave/brave-ui#497

Submitter Checklist:

Test Plan:

  1. Linking
  • clean profile
  • enable rewards
  • click on Verify wallet
  • make sure that you see on boarding
  • make sure that you are redirected to uphold side
  • sign in or create account (try with new profile, existing profile and existing kyc'd profile)
  • make sure that you are redirected back to rewards page
    • if you signed in with KYC'd account you should see green button saying verified
    • if you signed in with a regular account you should be redirected to uphold kyc page
  1. Contribution
  • clean profile
  • enable rewards
  • link to kyc'd wallet
  • tip one verified publisher
  • make sure that in your uphold account you see two transactions (5% that goes to brave and 95% that went to the publisher)
  1. Claim
  • clean profile
  • enable rewards
  • recover wallet that was self funded
  • link to kyc'd wallet
  • make sure that user funds from anon wallet are transferred to uphold account that you connected

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Jun 14, 2019
@NejcZdovc NejcZdovc force-pushed the uphold-wallet branch 2 times, most recently from 94a429a to d04318b Compare June 18, 2019 12:01
@NejcZdovc NejcZdovc changed the base branch from master to balance June 18, 2019 12:01
@NejcZdovc NejcZdovc changed the base branch from balance to master June 19, 2019 13:52
@NejcZdovc NejcZdovc force-pushed the uphold-wallet branch 7 times, most recently from f2862b7 to 6560a12 Compare June 20, 2019 15:29
@NejcZdovc NejcZdovc mentioned this pull request Jun 21, 2019
32 tasks
@NejcZdovc NejcZdovc force-pushed the uphold-wallet branch 4 times, most recently from f11ed94 to abf293d Compare June 23, 2019 13:11
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jun 24, 2019
@NejcZdovc NejcZdovc force-pushed the uphold-wallet branch 6 times, most recently from 4df18e8 to d307b59 Compare June 25, 2019 18:23
@tmancey tmancey requested review from tmancey and removed request for jasonrsadler July 23, 2019 08:39
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Member

@evq evq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving / merging as since last code owner approval this has only undergone a rebase where there was a single conflict in a mojo file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants