Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling Uphold wallet Connect/Disconnect #5005

Closed
mandar-brave opened this issue Jun 21, 2019 · 1 comment · Fixed by brave/brave-core#2696
Closed

Handling Uphold wallet Connect/Disconnect #5005

mandar-brave opened this issue Jun 21, 2019 · 1 comment · Fixed by brave/brave-core#2696

Comments

@mandar-brave
Copy link

image

@NejcZdovc this is optional for the first phase of user wallets.
Link 1: Just jump to the Uphold wallet
Link 2: Just remove the auth_token and put wallet to disconnect state (if there is an API to de-auth the token, make that call)

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 21, 2019
@mandar-brave mandar-brave added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 24, 2019
@NejcZdovc NejcZdovc self-assigned this Jul 8, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Nightly milestone Jul 8, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Sep 3, 2019

Verified passed with

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Verified test plan from Uphold wallet brave-core#2696
  • Verified that Go to my Uphold account opens Uphold dashboard in same tab
  • Verified that Disconnect from Brave Rewards disconnects you. Green verified button changes to gray disconnected button. Clicking on it reauthorizes you.
    Screen Shot 2019-09-03 at 5 12 25 PM

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
image
  • Verified test plan from Uphold wallet brave-core#2696
  • Verified that Go to my Uphold account opens Uphold dashboard in same tab
  • Verified that Disconnect from Brave Rewards disconnects you. Green verified button changes to gray disconnected button. Clicking on it reauthorizes you.

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from Uphold wallet brave-core#2696
  • Verified that Go to my Uphold account opens Uphold dashboard in the same tab
  • Verified that Disconnect from Brave Rewards disconnects you. Green verified button changes to gray disconnected button. Clicking on it reauthorizes you.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants