Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User wallet: Add fund flow #4779

Closed
mandar-brave opened this issue Jun 10, 2019 · 2 comments · Fixed by brave/brave-core#2696
Closed

User wallet: Add fund flow #4779

mandar-brave opened this issue Jun 10, 2019 · 2 comments · Fixed by brave/brave-core#2696

Comments

@mandar-brave
Copy link

Old add funds flow needs to go.
Only users with Uphold wallets can add funds.
Add funds is handed off to Uphold for managing transfers in initial release

@NejcZdovc
@jenn-rhim for UI/UX changes.
cc @alexwykoff

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 10, 2019
@mandar-brave
Copy link
Author

For Add-funds, the link should take user to Uphold site with the right URL to allow user to add funds on Uphold site
For With-funds, the link should take user to Uphold account

image

@mandar-brave mandar-brave added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jun 24, 2019
@NejcZdovc NejcZdovc added this to the 0.69.x - Nightly milestone Jul 8, 2019
@NejcZdovc NejcZdovc self-assigned this Jul 8, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Sep 3, 2019

Verified passed with

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X
  • Verified test plan from Uphold wallet brave-core#2696

  • Verified if you've never connected an uphold account, Add Funds and Withdraw Funds take you to onboarding modal
    Screen Shot 2019-09-03 at 5 40 27 PM

  • Verified if you connect an account that is not KYC'd, and you click on Add Funds, you are taken to your Add Funds page for your Brave Browser Card (note - without KYC not all options will be available to the user)
    Screen Shot 2019-09-03 at 5 42 11 PM

  • Verified if you connect an account that is not KYC'd and you click on Withdraw Funds, you are taken to a page to complete KYC
    Screen Shot 2019-09-03 at 5 42 28 PM

  • Verified if you connect a KYC'd Uphold account and click on Add Funds, you are taken to your Add Funds page for your Brave Browser Card
    Screen Shot 2019-09-03 at 5 44 21 PM

  • Verified if you connect a KYC'd Uphold account and click on Withdraw Funds, you are taken to the 'Use Funds' page for your Brave Browser card:
    Screen Shot 2019-09-03 at 5 44 35 PM

Verification passed on

Brave 0.69.123 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • Verified test plan from Uphold wallet brave-core#2696

  • Verified if you've never connected an uphold account, Add Funds and Withdraw Funds take you to onboarding modal
    image

  • Verified if you connect an account that is not KYC'd, and you click on Add Funds, you are taken to your Add Funds page for your Brave Browser Card (note - without KYC not all options will be available to the user)
    image

  • Verified if you connect an account that is not KYC'd and you click on Withdraw Funds, you are taken to a page to complete KYC
    image

  • Verified if you connect a KYC'd Uphold account and click on Add Funds, you are taken to your Add Funds page for your Brave Browser Card
    image

  • Verified if you connect a KYC'd Uphold account and click on Withdraw Funds, you are taken to the 'Use Funds' page for your Brave Browser card:
    image

Verification passed on

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from Uphold wallet brave-core#2696
  • Verified if you've never connected an uphold account, Add Funds and Withdraw Funds take you to onboarding modal

image

  • Verified if you connect an account that is not KYC'd, and you click on Add Funds, you are taken to your Add Funds page for your Brave Browser Card (note - without KYC not all options will be available to the user)

image

  • Verified if you connect an account that is not KYC'd and you click on Withdraw Funds, you are taken to a page to complete KYC

image

  • Verified if you connect a KYC'd Uphold account and click on Withdraw Funds, you are taken to the 'Use Funds' page for your Brave Browser card:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants