Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{{balancse}} being displayed when restoring wallet under Norwegian locale #4880

Closed
kjozwiak opened this issue Jun 13, 2019 · 8 comments
Closed

Comments

@kjozwiak
Copy link
Member

Description

Once you've imported a wallet within Brave using the Norwegian locale, the success message will display {{balanse}} instead of the BAT balance that was restored.

Steps to Reproduce

  1. ensure that your region and language is set to Norwegian
  2. import a brave wallet with a balance

Actual result:

Screen Shot 2019-06-12 at 11 48 47 PM

Expected result:

When restoring a wallet within Brave, it should display the correct balance being restored rather than {{balanse}}.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.66.88 Chromium: 75.0.3770.87 (Official Build) beta(64-bit)
Revision 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes, 0.65.118 CR: 75.0.3770.80
  • Can you reproduce this issue with the beta channel? Yes, using 0.66.88 CR: 75.0.3770.87
  • Can you reproduce this issue with the dev channel? Yes, using 0.67.79 CR: 75.0.3770.80
  • Can you reproduce this issue with the nightly channel? Yes, using 0.68.39 CR: 75.0.3770.87

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @brave/legacy_qa

@NejcZdovc
Copy link
Contributor

this needs to be fixed on transifix site as someone translated what is in curly brackets. In there should be {{balance}}. Because it was translated now we can't replace placeholder with a value

@kjozwiak
Copy link
Member Author

@NejcZdovc who usually fixes issues on transifix?

@NejcZdovc
Copy link
Contributor

@kjozwiak not sure

@kjozwiak
Copy link
Member Author

@mkarolin mind taking a look at this?

@mkarolin
Copy link
Contributor

mkarolin commented Jun 13, 2019

Fixed on Transifex. We can pull updated translations as a part of c75.0.3770.90 bump. cc: @bsclifton

@bsclifton
Copy link
Member

@mkarolin SGTM! 😄

@kjozwiak
Copy link
Member Author

kjozwiak commented Jun 14, 2019

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Mac OS X

Skjermbilde 2019-06-14 kl  07 36 58

Verification passed on

Brave 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Windows 7 Service Pack 1 (Build 7601.24468)

image

@srirambv
Copy link
Contributor

  • Verification passed on
Brave 0.65.120 Chromium: 75.0.3770.90 (Official Build) (64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Linux

image

tmancey pushed a commit that referenced this issue Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment