Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patch file removal when no changes to chromium src for a file #49

Closed
bbondy opened this issue Jan 8, 2018 · 0 comments
Closed

Add patch file removal when no changes to chromium src for a file #49

bbondy opened this issue Jan 8, 2018 · 0 comments

Comments

@bbondy
Copy link
Member

bbondy commented Jan 8, 2018

There's a slight problem with split patches.
If you remove all changes from a chromium source file, and you run update patches, it will not git rm the patch file. It just leaves it as is so you have to remember to manually also remove the patch file when you get the last change out from a modified chromium src file.

The way it works now is it doesn't create an empty patch file, it just leaves the patch file with the changes that were in there last.

Eventually someone will forget to manually remove the old unchanged patch file if they are doing lots of changes.

kevinlawler referenced this issue Jan 9, 2018
brave/brave#49

rm cruft patches in addition to notifying
cezaraugusto pushed a commit that referenced this issue May 15, 2018
Import bookmark & history from chrome/chrome canary/chromium
@bbondy bbondy added this to the Backlog milestone Jun 6, 2018
@bbondy bbondy closed this as completed in 72af8c9 Jul 6, 2018
@bbondy bbondy modified the milestones: Backlog, Releasable builds Jul 6, 2018
@bbondy bbondy added the QA/No label Aug 18, 2018
petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
Fix brave/brave-browser#49

rm cruft patches in addition to notifying
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
Fix brave/brave-browser#49

rm cruft patches in addition to notifying
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant