Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to clear browsing data on exit #492

Closed
srirambv opened this issue Jul 5, 2018 · 42 comments · Fixed by brave/brave-core#1213
Closed

Option to clear browsing data on exit #492

srirambv opened this issue Jul 5, 2018 · 42 comments · Fixed by brave/brave-core#1213
Assignees
Labels
browser-laptop-parity design A design change, especially one which needs input from the design team enhancement feature/history priority/P3 The next thing for us to work on. It'll ride the trains. privacy/feature User-facing privacy- & security-focused feature work. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include suggestion

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 5, 2018

Test plan

See brave/brave-core#1213

Description

Brave-core doesn't have an option to clear browsing history/cache upon browser exit. It would be great to have this option to bridge parity between browser-laptop and brave-core

screen shot 2018-09-09 at 1 31 51 am

@eljuno
Copy link

eljuno commented Sep 29, 2018

+1 from community https://community.brave.com/t/clear-data-on-close-missing/33647?u=eljuno

@diracdeltas
Copy link
Member

+1 from me, i use this in b-l

@NumDeP
Copy link

NumDeP commented Oct 31, 2018

+1 For your information, when this feature is implemented, create numerous tests to check whether selected data has actually cleared on exit. On the Muon-Linux version, I had to manually click the orange 'Clear Browsing Data Now...' for it to prompt Restart Browser Now and clicking it every time for it to actually erase data on exit, which it did afterwards but never did it erase properly by just leaving it on Clear data on exit.

One way I noticed is when certain sites would show numerous familiar content and another easy way to deduce it was checking to see if recent links on a search engine were still highlighted (purple)

@rebron rebron added design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Nov 5, 2018
@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 6, 2018
@NejcZdovc
Copy link
Contributor

+1 from me

@warwickmm
Copy link

+1 from me

@eljuno
Copy link

eljuno commented Nov 23, 2018

@srirambv
Copy link
Contributor Author

@srirambv
Copy link
Contributor Author

@srirambv
Copy link
Contributor Author

@kjozwiak @rebron @bbondy we need to prioritize this as well. Been seeing a lot of +1's from community.

@ghug
Copy link

ghug commented Mar 11, 2019

'Clear browsing history on exit' doesn't currently override the brave://settings/onStartup setting. If onStartup is set to "Continue where you left off" any open tabs are still remembered and re-opened on startup even if browsing history is cleared on exit. Perhaps this is intended, but it doesn't seem completely intuitive to me.

@rebron
Copy link
Collaborator

rebron commented Mar 11, 2019

@gabrielhug I don't think 'Clear browsing history on exit' should override that on start up setting. People can change that setting back to New Tab page or a page/set of pages they want instead.

@FrederickDavies
Copy link

Is something like this (options to delete stuff on exit) going to be implemented on the Android version of Brave?

FD

@bsclifton
Copy link
Member

bsclifton commented Mar 11, 2019

@FrederickDavies good question -
Looks like it's being tracked with https://github.com/brave/browser-android-tabs/issues/93 in case you wanted to give it a thumbs up 😄

cc: @anthonypkeane @SergeyZhukovsky

@FrederickDavies
Copy link

How do you find out when the fix is due to come out into the Brave Core auto-update stream?

FD

@kjozwiak
Copy link
Member

How do you find out when the fix is due to come out into the Brave Core auto-update stream?

FD

Here's a few methods/checks that you can use to see where a certain fix is landing:

With the above information, you know that it's landing in 0.63.x, as a double check, you can make sure that the PR is appearing in the 0.63.x tree:

@FrederickDavies
Copy link

FrederickDavies commented Mar 20, 2019 via email

@babbage1986
Copy link

There is a Chrome extension, Click&Clean, which does this job perfectly but it does not run on Brave (I think it does run on the Dev release). Please can we activate this extension and solve the issue.

@srirambv
Copy link
Contributor Author

srirambv commented Mar 25, 2019

Verification passed on

Brave 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

image

Verification passed on

Brave 0.63.20 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

image

Verified passed with

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

@babbage1986
Copy link

Thanks! Click&Clean now works. Better still the new settings illustrated above are the ideal solution.

@rebron rebron changed the title Option to clear history/cache when browser closed/quit Option to clear browsing data on exit Apr 17, 2019
@balupton
Copy link

balupton commented Aug 27, 2020

What's the latest for this?

Nevermind, found it.

I hope however this can be an ever-present selection, such that the browser always deletes everything on exit.

@babbage1986
Copy link

This is pretty much out of date. I no longer use the Click&Clean extension, the settings in Brave do what I need, i.e., on exit delete all cookies except those I explicitly specify. If Safari had this option I'd switch but it doesn't.

@FrederickDavies
Copy link

It seems the Android ticket has disappeared; anyone know if there is something like this (options to delete stuff on exit) on the Android version of Brave?

FD

@WilliamShockleyfake
Copy link

I want this feature on android brave as well

@kjozwiak
Copy link
Member

I want this feature on android brave as well

Added a +1 from you via #7487 which is the issue tracking the work for implementing the above on Android.

@WilliamShockleyfake
Copy link

When will you guys add this feature on android. I am done waiting. Is it so hard to implement?

@anthonypkeane
Copy link

It is available on the Beta version now and we should have it on the main app in a few weeks @WilliamShockleyfake

@ghost
Copy link

ghost commented May 30, 2021

Wish we could select which data we wanted to erase on exit, and not just one option to "erase everything".

@AdamGeo
Copy link

AdamGeo commented Jun 17, 2021

Any idea when this is coming? There's been 2 updates recently but still no option for this, unless it's hidden somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity design A design change, especially one which needs input from the design team enhancement feature/history priority/P3 The next thing for us to work on. It'll ride the trains. privacy/feature User-facing privacy- & security-focused feature work. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.