Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad notifications received this month should not include transaction count from server #5119

Closed
tmancey opened this issue Jul 3, 2019 · 1 comment · Fixed by brave/brave-core#2851

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 3, 2019

Description

Ad notifications received this month should not include transaction count from server

Steps to Reproduce

  1. Cash-in confirmations in July
  2. Wait for pay out in August

Actual result:

Ad notifications received this month is calculated from the transaction count from server and any unredeemed transactions

Expected result:

Ad notifications received this month should be calculated by how many ads were seen on a particular month irrespective if they were redeemed

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented Jul 26, 2019

Verified passed with

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Verified passed with

Brave 0.67.117 Chromium: 76.0.3809.62 (Official Build) (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.67.119 Chromium: 76.0.3809.72 (Official Build) (64-bit)
Revision 5a04c669126f657f98824b436555cae41b8f4146-refs/branch-heads/3809@{#897}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the test plan on the clean profile as well as on upgraded profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants