Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AutoContributeProps to mojo interface #5127

Closed
NejcZdovc opened this issue Jul 4, 2019 · 0 comments · Fixed by brave/brave-core#2884
Closed

Move AutoContributeProps to mojo interface #5127

NejcZdovc opened this issue Jul 4, 2019 · 0 comments · Fixed by brave/brave-core#2884
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Milestone
0.69.x - Release

Comments

@NejcZdovc
Copy link
Contributor

We need to move AutoContributeProps in vendor/bat-native-ledger/include/bat/ledger/auto_contribute_props.h into mojo interface.

Example how to do this brave/brave-core#2432
@NejcZdovc NejcZdovc added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. dev-concern labels Jul 4, 2019
@cg505 cg505 self-assigned this Jul 8, 2019
@cg505 cg505 added this to the 0.69.x - Nightly milestone Jul 8, 2019
@cg505 cg505 mentioned this issue Jul 8, 2019
Merged
32 tasks
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Jul 11, 2019
@cg505 @NejcZdovc
move AutoContributeProps to mojo interface
886fc84 
Fixes brave/brave-browser#5127.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

move AutoContributeProps to mojo interface brave/brave-core
3 participants
@cg505 @bsclifton @NejcZdovc