Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ReconcileInfo to mojo interface #5131

Closed
NejcZdovc opened this issue Jul 4, 2019 · 0 comments · Fixed by brave/brave-core#2889
Closed

Move ReconcileInfo to mojo interface #5131

NejcZdovc opened this issue Jul 4, 2019 · 0 comments · Fixed by brave/brave-core#2889
Assignees
@cg505
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Milestone
0.69.x - Release

Comments

@NejcZdovc
Copy link
Contributor

We need to move ReconcileInfo in vendor/bat-native-ledger/include/bat/ledger/reconcile_info.h into mojo interface.

Example how to do this brave/brave-core#2432
@NejcZdovc NejcZdovc added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. dev-concern labels Jul 4, 2019
@cg505 cg505 mentioned this issue Jul 9, 2019
Closed
@cg505 cg505 self-assigned this Jul 9, 2019
@cg505 cg505 added this to the 0.69.x - Nightly milestone Jul 10, 2019
@cg505 cg505 mentioned this issue Jul 10, 2019
Merged
32 tasks
cg505 added a commit to brave/brave-core that referenced this issue Jul 13, 2019
@cg505
move RewardsInternalsInfo to mojo type and use callback
5d35c09 
Resolves brave/brave-browser#5131.
Resolves brave/brave-browser#5132.
Resolves brave/brave-browser#5146.
@cg505 cg505 modified the milestones: 0.69.x - Dev, 0.70.x - Nightly Jul 23, 2019
cg505 added a commit to brave/brave-core that referenced this issue Jul 26, 2019
@cg505
move RewardsInternalsInfo to mojo type and use callback
607b3da 
Resolves brave/brave-browser#5131.
Resolves brave/brave-browser#5132.
Resolves brave/brave-browser#5146.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cg505 cg505

Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

move RewardsInternalsInfo to mojo type and use callback brave/brave-core
3 participants
@cg505 @kjozwiak @NejcZdovc