Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback to GetGrantCaptcha #5140

Closed
NejcZdovc opened this issue Jul 4, 2019 · 1 comment · Fixed by brave/brave-core#2940
Closed

Add callback to GetGrantCaptcha #5140

NejcZdovc opened this issue Jul 4, 2019 · 1 comment · Fixed by brave/brave-core#2940
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Milestone
0.69.x - Release

Comments

@NejcZdovc
Copy link
Contributor

We need to add callback to GetGrantCaptcha inside vendor/bat-native-ledger/include/bat/ledger/ledger.h.

When adding callback be carful what is called inside this functions. Make sure that you handle all use cases that they were previous handled via ledger_client.h functions that then called client back.
@NejcZdovc NejcZdovc added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. dev-concern labels Jul 4, 2019
@jdkuki jdkuki self-assigned this Jul 16, 2019
@jdkuki jdkuki mentioned this issue Jul 17, 2019
Merged
32 tasks
jdkuki added a commit to brave/brave-core that referenced this issue Jul 17, 2019
@jdkuki
Refactor GetGrantCaptcha to use callback
8584882 
Resolves brave/brave-browser#5140
@jdkuki jdkuki changed the title Add callback to SolveGrantCaptcha Add callback to GetGrantCaptcha Jul 18, 2019
@NejcZdovc NejcZdovc added this to the 0.70.x - Nightly milestone Jul 25, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jul 25, 2019
@jdkuki
Refactor GetGrantCaptcha to use callback
6393375 
Resolves brave/brave-browser#5140
@btlechowski
Copy link

Could you add QA/Yes or QA/No label to the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/No release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Refactor GetGrantCaptcha to use callback brave/brave-core
4 participants
@jdkuki @NejcZdovc @LaurenWags @btlechowski