You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After brave/brave-core#2857 we have two locales for the same features, one for brave-core (real one that goes to Transifex) and another one for storybook prototyping (named fakeLocale).
Ideally we could have both places using the same source. As far as I know Storybook can only read JavaScript, so maybe outputting results in .grd files as JSON? I don't think it's possible without much work but having a single JSON file similar to extension's messages would be ideal.
cc @petemill@mkarolin I don't think this is top priority but would be cool to have your input about what we can do right now with as low effort/time as possible.
The text was updated successfully, but these errors were encountered:
@NejcZdovc that's a good point, unless we start to use the c++ IDs in JS and remove the go-between layer, e.g. locale.getString('IDS_BRAVE_WELCOME_PAGE_MAIN_TITLE')
After brave/brave-core#2857 we have two locales for the same features, one for brave-core (real one that goes to Transifex) and another one for storybook prototyping (named fakeLocale).
Ideally we could have both places using the same source. As far as I know Storybook can only read JavaScript, so maybe outputting results in
.grd
files as JSON? I don't think it's possible without much work but having a single JSON file similar to extension's messages would be ideal.cc @petemill @mkarolin I don't think this is top priority but would be cool to have your input about what we can do right now with as low effort/time as possible.
The text was updated successfully, but these errors were encountered: