-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customization panel should not be open by default on New Tab page #5199
Comments
The first time someone opens NTP the settings menu would be off. I believe the current behavior you are experiencing is:
If that's the case, the menu would persist over to the next NTP session. |
@imptrx That's the case. Don't preserve the last session of the settings menu when user opens up a new tab page. Should always show closed when creating a new tab page. |
Test Plan:
|
@imptrx I suggest you use component state and not redux state for the openness of the menu, or just delete the redux property when the redux state is saved to localStorage |
@petemill I currently have a "close menu" action attached to NTP component mount but I'll probably move that logic out of redux as you suggest 👍 |
… menu is keyboard accessible; closes brave/brave-browser#5041; closes /brave/brave-browser/issues/5199
Verification passed on
Verification passed on
Verification PASSED on
|
Description
Currently, the customization panel is open by default on New Tab page.
Fix this so that the panel is not open by default.
The text was updated successfully, but these errors were encountered: