Support priority for Brave Ads #5232

jsecretan · 2019-07-12T17:22:22Z

Description

Certain campaigns may need to be prioritized over others for a number of reasons. If certain campaigns have commitments attached to them and are underdelivering, they may need to serve over others available. This is common practice in ad trafficking.

This is dependent on the completion of #5231. On the campaign level, there is a "priority" field with a numerical value from 1-10, 1 meaning the highest priority. For the list of available ads to serve, the native ad library should sort eligible ads ascending by this value, and select by the highest priority first.

The round robin algorithm (#5945) would also change to work first within higher priority levels before going to lower priority levels.

tmancey · 2019-12-06T14:44:52Z

@jsecretan Assigning to see if this issue is still relevant, thanks

tmancey · 2020-01-22T09:55:16Z

Blocked while deciding if this issue is still relevant

btlechowski · 2020-07-06T18:39:10Z

@tmancey I noticed that if there is priority > 1 then it possible that the Ad will not be shown. Is that expected? Seems weird because when this happens, we will need to wait for another ad trigger.

[11790:11790:0706/203719.194339:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[11790:11790:0706/203719.194423:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(10):5]

tmancey · 2020-07-07T07:29:06Z

@btlechowski This is correct, and I can go into further detail on a call later today. Thanks

btlechowski · 2020-07-10T15:40:14Z

Important: When an ad is about to be shown, the new system makes a roll based on ad priority.
Priority 1 - 100% chance to be shown
Priority 2 - 50% chance to be shown
Priority 10 - 10% chance to be shown

For sanity check use: Ads with different priorities - the higher priority the sooner ad is shown

Test plan

Ads with priority 1 - always shown

Load staging catalog ads_priority_1.txt
Show each ad 2 times

Expected:
When ad is chosen to be shown, it is always shown
The ads are shown according to round robin

Ads with priority 2 - 50% chance to show

Load staging catalog ads_priority_2.txt
Show each ad 2 times

Expected:
The chosen ad has 50% chance to be shown
The ads are shown according to round robin

Ad with priority 0 - never shown

Load staging catalog ads_priority_0.txt
Try to show the ad

Expected:
The ad is never shown

Ads with different priorities - the higher priority the sooner ad is shown

Load staging catalog: ads_priority_mixed.txt
Show each ad 2 times

Expected:
Ads with priority 1 are shown first, Ads with priority 2 are shown next, Ads with priority 3 are shown last
Round robin happens after all ads are shown

Ad priority is changed in the catalog

Load staging catalog: ads_priority_changing_1000.txt
Try to show the ad that has priority 1000
Close Brave
Load staging catalog: ads_priority_changing_1.txt
Show the same ad that has priority changed to 1

Expected:
Ad p1 is shown

Catalog is updated with ad with higher priority

Load staging catalog: ads_priority_new_ad_1.txt
Try to show the ad that has priority 1000
Load staging catalog: ads_priority_new_ad_2.txt
Wait till the new catalog is downloaded
Show the new ad that have priority 1

Expected:
Ad p1 is shown

btlechowski · 2020-07-10T15:49:05Z

Verification passed on

Brave	1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
Revision	e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS	Ubuntu 18.04 LTS

Verified test plan from #5232 (comment)

Verified Ads with priority 1 - always shown
First ad shown:

[4604:4604:0710/153318.479032:VERBOSE1:ads_impl.cc(896)] Serving ad notification from untargeted category
[4604:4604:0710/153318.486258:VERBOSE2:ads_impl.cc(992)] 3 eligible ads with a priority of 1

Second Ad

[5147:5147:0710/164119.840907:VERBOSE2:ads_impl.cc(992)] 2 eligible ads with a priority of 1

Third Ad

[5147:5147:0710/174253.636468:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1

Verified Round robin works:

Ad CCC
Ad BBB
Ad AAA

Ad BBB
Ad AAA
Ad CCC

Verified Ads with priority 2 - 50% chance to show
First ad was not shown due to the roll:

[5779:5779:0710/155357.064462:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(2):2]

Ad was shown on second attempt:

[5779:5779:0710/155719.726763:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
title: Ad CCC

Next ad shown:

[5779:5779:0710/170050.640117:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 2
[5779:5779:0710/170050.646733:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  title: Ad AAA

Next ad shown:

[5779:5779:0710/180539.327375:VERBOSE2:ads_impl.cc(992)] 2 eligible ads with a priority of 2
[5779:5779:0710/180539.328123:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  title: Ad CCC

Next ad shown:

[5779:5779:0710/190702.102603:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 2
[5779:5779:0710/190702.105581:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  title: Ad AAA

Ad was not shown due to the roll:

[5779:5779:0710/200956.685530:VERBOSE2:ads_impl.cc(992)] 2 eligible ads with a priority of 2
[5779:5779:0710/200956.685789:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(2):2]

Ad was shown on second attempt:

[5779:5779:0710/201135.192787:VERBOSE2:ads_impl.cc(992)] 2 eligible ads with a priority of 2
  title: Ad CCC

Verified Round robin works:

Ad CCC
Ad AAA

Ad CCC
Ad AAA

Ad CCC

Verified Ad with priority 0 - never shown
Ad was not shown, the log message:

[6614:6614:0710/202200.229131:VERBOSE2:ads_impl.cc(992)] 0 eligible ads with a priority of 1264684032

Verified Ads with different priorities - the higher priority the sooner ad is shown
First ad with priority 1 was shown

[7282:7282:0710/163025.324414:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1
[7282:7282:0710/163025.324467:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 2
[7282:7282:0710/163025.324504:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[7282:7282:0710/163025.324800:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  title: Ad CCC

Attempt on showing 2nd ad:

[7282:7282:0710/173331.082135:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 2
[7282:7282:0710/173331.082226:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[7282:7282:0710/173331.082339:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[7282:7282:0710/173331.082391:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(2):2]

2nd ad shown

[7282:7282:0710/173634.336909:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 2
[7282:7282:0710/173634.337040:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[7282:7282:0710/173634.337108:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[7282:7282:0710/173634.337764:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  title: Ad BBB

3rd ad shown:

[7282:7282:0710/183836.615439:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[7282:7282:0710/183836.616410:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[7282:7282:0710/183836.617757:VERBOSE3:client.cc(580)] Saving client state
[7282:7282:0710/183836.622446:VERBOSE3:client.cc(580)] Saving client state
[7282:7282:0710/183836.624039:VERBOSE3:client.cc(580)] Saving client state
[7282:7282:0710/183836.625178:VERBOSE3:client.cc(580)] Saving client state
[7282:7282:0710/183836.625357:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  title: Ad AAA

4th ad shown:

[7282:7282:0710/194039.996995:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1
[7282:7282:0710/194039.997274:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 2
[7282:7282:0710/194039.997942:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[7282:7282:0710/194039.998038:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[7282:7282:0710/194040.005690:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  title: Ad CCC

5th ad shown:

[7282:7282:0710/204150.415608:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 2
[7282:7282:0710/204150.415785:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[7282:7282:0710/204150.415897:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[7282:7282:0710/204150.417741:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  title: Ad BBB

6th ad attempt:

[7282:7282:0710/214252.041282:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[7282:7282:0710/214252.043294:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[7282:7282:0710/214252.043424:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):3]

Another 6th ad attempt:

[7282:7282:0710/215044.814788:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[7282:7282:0710/215044.814992:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[7282:7282:0710/215044.815130:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):2]

6th ad shown:

[7282:7282:0710/215452.174915:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[7282:7282:0710/215452.176219:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[7282:7282:0710/215452.183749:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  title: Ad AAA

Verified Round robin works:
Important: The order must always be the same due to priorities

Ad CCC
Ad BBB
Ad AAA

Ad CCC
Ad BBB
Ad AAA

Verified Ad priority is changed in the catalog
Ad p1 was shown

[9706:9706:0710/171550.333648:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1
[9706:9706:0710/171550.335361:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[9706:9706:0710/171550.335463:VERBOSE3:client.cc(580)] Saving client state
[9706:9706:0710/171550.335558:VERBOSE3:client.cc(580)] Saving client state
[9706:9706:0710/171550.335625:VERBOSE3:client.cc(580)] Saving client state
[9706:9706:0710/171550.335688:VERBOSE3:client.cc(580)] Saving client state
[9706:9706:0710/171550.335778:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  uuid: b2a0b1e7-4b64-45d3-916d-4b41df5303ab
  parentUuid: e9cdc442-bac9-4752-bf62-4641ed65c3e4
  creativeInstanceId: d4e390fc-424b-4b2c-895e-df8475ea8b45
  creativeSetId: ba85501d-f1cb-407f-a5ba-2d4b4cec7f3c
  category: untargeted
  title: Ad p1
  body: Ad p1

Verified Catalog is updated with ad with higher priority
Ad p1 was shown

[10345:10345:0711/185025.760168:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1
[10345:10345:0711/185025.761270:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 10
[10345:10345:0711/185025.762193:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[10345:10345:0711/185025.763714:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  uuid: e3894d74-fb1d-4520-9558-0c58ccadbdcd
  parentUuid: b570a45f-e0d6-4f70-b0e5-9fa8b9cc95d2
  creativeInstanceId: d9dc0028-8f86-4c92-b25d-981bc1bdb903
  creativeSetId: dea8df38-27b6-4b53-a699-77629934db80
  category: untargeted
  title: Ad p1
  body: Ad p1

Verified passed with

Brave | 1.11.96 Chromium: 84.0.4147.89 (Official Build) (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)

Per discussion with @btlechowski and @kjozwiak only checked the Ads with different priorities - the higher priority the sooner ad is shown test case from #5232 (comment)

First Ad with priority 1 shown:

[14173:775:0714/083425.170397:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1
[14173:775:0714/083425.170465:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 2
[14173:775:0714/083425.170519:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[14173:775:0714/083425.170563:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

Ad title of ad shown: CCC

Second Ad with priority 2 shown:

[14173:775:0714/084703.658449:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 2
[14173:775:0714/084703.658535:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[14173:775:0714/084703.658589:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

Ad title of ad shown: BBB

Attempt to show 3rd ad:

[14173:775:0714/085927.138682:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/085927.138742:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/085927.138783:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):2]

Attempt to show 3rd ad:

[14173:775:0714/090045.188338:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/090045.188395:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/090045.188435:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):2]

Attempt to show 3rd ad:

[14173:775:0714/090132.219043:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/090132.219126:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/090132.219186:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):3]

Third ad with priority 3 shown:

[14173:775:0714/090251.268984:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/090251.269030:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

Ad title of ad shown: AAA

Prior to showing 4th ad:

[14173:775:0714/092751.802968:VERBOSE1:ads_impl.cc(1123)] All advertisers have been shown, so round robin
[14173:775:0714/092751.803036:VERBOSE1:client.cc(420)] Resetting seen advertisers

Fourth Ad with priority 1 shown:

[14173:775:0714/095022.249799:VERBOSE2:ads_impl.cc(1065)] adUUID 6a66e391-9a1d-4349-8a04-64751edf692b has exceeded the frequency capping for perHour
[14173:775:0714/095022.250209:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1
[14173:775:0714/095022.250265:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 2
[14173:775:0714/095022.250311:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

Ad title of ad shown: CCC

Fifth Ad with priority 2 shown:

[14173:775:0714/110220.565838:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 2
[14173:775:0714/110220.565947:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[14173:775:0714/110220.566032:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

Ad title of ad shown: BBB

Attempt to show 6th ad:

[14173:775:0714/111950.266665:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/111950.266724:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/111950.266765:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):3]

Attempt to show 6th ad:

[14173:775:0714/112044.310828:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/112044.310876:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/112044.310910:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):3]

Attempt to show 6th ad:

[14173:775:0714/112126.337485:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/112126.337528:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/112126.337561:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):2]

Attempt to show 6th ad:

[14173:775:0714/112314.407575:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/112314.407622:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/112314.407656:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):3]

Attempt to show 6th ad:

[14173:775:0714/112645.543905:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/112645.543957:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/112645.543996:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):2]

Attempt to show 6th ad:

[14173:775:0714/113239.671072:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/113239.671191:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/113239.671456:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):3]

Attempt to show 6th ad:

[14173:775:0714/113318.696307:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/113318.696361:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/113318.696400:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):2]

Attempt to show 6th ad:

[14173:775:0714/113428.770503:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/113428.770555:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/113428.770593:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):3]

Attempt to show 6th ad:

[14173:775:0714/113504.798494:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/113504.798555:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/113504.798595:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):3]

Attempt to show 6th ad:

[14173:775:0714/114025.004770:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/114025.004829:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/114025.004867:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):3]

Attempt to show 6th ad:

[14173:775:0714/114429.161902:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/114429.161955:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/114429.161991:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):2]

Attempt to show 6th ad:

[14173:775:0714/114606.227097:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/114606.227157:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[14173:775:0714/114606.227196:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):3]

Sixth ad with priority 3:

[14173:775:0714/124721.111605:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[14173:775:0714/124721.111657:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

Ad title of ad shown: AAA

Confirmed Round robin works and the order of ads shown was the same due to priorities

Verification passed on


Brave | 1.11.96 Chromium: 84.0.4147.89 (Official Build) (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.900)

Tested Ads with different priorities - the higher priority the sooner ad is shown test case from Support priority for Brave Ads #5232 (comment)

First Ad shown:

[7016:19100:0715/150550.243:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1
[7016:19100:0715/150550.243:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 2
[7016:19100:0715/150550.243:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[7016:19100:0715/150550.243:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

2nd Ad shown:

[7016:19100:0715/160901.984:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 2
[7016:19100:0715/160901.984:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[7016:19100:0715/160901.984:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

3rd Ad shown:

[21580:23744:0715/171311.711:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[21580:23744:0715/171311.711:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[21580:23744:0715/171311.711:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):2]

4th Ad shown:

[21580:23744:0715/181648.200:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1
[21580:23744:0715/181648.200:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 2
[21580:23744:0715/181648.200:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[21580:23744:0715/181648.200:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

2nd Ad shown:

[21580:23744:0715/192037.948:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 2
[21580:23744:0715/192037.948:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[21580:23744:0715/192037.948:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

3rd Ad shown:

[21580:23744:0715/202239.216:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[21580:23744:0715/202239.216:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

4th Ad shown:

[21580:23744:0715/212522.629:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1
[21580:23744:0715/212522.629:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 2
[21580:23744:0715/212522.629:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[21580:23744:0715/212522.629:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

2nd Ad shown:

[21580:23744:0715/223106.557:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 2
[21580:23744:0715/223106.557:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[21580:23744:0715/223106.557:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[21580:23744:0715/223106.557:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(2):2]

3rd Ad shown:

[21580:23744:0715/233402.607:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 3
[21580:23744:0715/233402.607:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads
[21580:23744:0715/233402.607:VERBOSE1:ads_impl.cc(1015)] Ad notification not shown: Pacing ad delivery [Roll(3):2]

4th Ad shown

[22312:20632:0716/223957.836:VERBOSE2:ads_impl.cc(992)] 1 eligible ads with a priority of 1
[22312:20632:0716/223957.836:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 2
[22312:20632:0716/223957.836:VERBOSE2:ads_impl.cc(1000)] 1 ads with a priority of 3
[22312:20632:0716/223957.836:VERBOSE1:ads_impl.cc(944)] Found 1 eligible ads

jsecretan added priority/P3 The next thing for us to work on. It'll ride the trains. feature/ads labels Jul 12, 2019

tmancey self-assigned this Jul 17, 2019

tmancey removed their assignment Aug 22, 2019

tmancey assigned tmancey and jsecretan and unassigned tmancey Nov 29, 2019

tmancey added the QA/Yes label Jan 20, 2020

tmancey changed the title ~~Support priority for ads~~ Support priority for Brave Ads Jan 20, 2020

tmancey added enhancement blocked labels Jan 20, 2020

tmancey removed QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 21, 2020

tmancey added needs-more-info The report requires more detail before we can decide what to do with this issue. and removed blocked labels May 16, 2020

tmancey assigned tmancey and unassigned jsecretan May 20, 2020

tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels May 20, 2020

tmancey mentioned this issue May 26, 2020

Support priority for Brave Ads brave/brave-core#5663

Merged

32 tasks

tmancey closed this as completed in brave/brave-core#5663 Jun 3, 2020

tmancey added this to the 1.11.x - Nightly milestone Jun 3, 2020

btlechowski added the QA/Blocked label Jul 6, 2020

btlechowski removed the QA/Blocked label Jul 7, 2020

This was referenced Jul 8, 2020

Manual test run on OS X for 1.11.x - Beta #10603

Closed

Manual test run on Windows x64 for 1.11.x - Beta #10604

Closed

Manual test run on Linux for 1.11.x - Beta #10605

Closed

btlechowski added the QA Pass-Linux label Jul 10, 2020

btlechowski mentioned this issue Jul 10, 2020

[Desktop] Huge ads priority in logs when priority is set to zero #10694

Closed

LaurenWags added the QA Pass-macOS label Jul 14, 2020

GeetaSarvadnya added the QA Pass-Win64 label Jul 15, 2020

LaurenWags mentioned this issue Jul 15, 2020

[Desktop] Release Notes for 1.11.x (Release Channel) #10752

Closed

tmancey added this to Ads Jun 10, 2024

tmancey moved this to Done in Ads Jun 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support priority for Brave Ads #5232

Support priority for Brave Ads #5232

jsecretan commented Jul 12, 2019 •

edited

Loading

tmancey commented Dec 6, 2019

tmancey commented Jan 22, 2020

btlechowski commented Jul 6, 2020 •

edited

Loading

tmancey commented Jul 7, 2020

btlechowski commented Jul 10, 2020 •

edited

Loading

btlechowski commented Jul 10, 2020 •

edited by GeetaSarvadnya

Loading

Support priority for Brave Ads #5232

Support priority for Brave Ads #5232

Comments

jsecretan commented Jul 12, 2019 • edited Loading

Description

tmancey commented Dec 6, 2019

tmancey commented Jan 22, 2020

btlechowski commented Jul 6, 2020 • edited Loading

tmancey commented Jul 7, 2020

btlechowski commented Jul 10, 2020 • edited Loading

Test plan

btlechowski commented Jul 10, 2020 • edited by GeetaSarvadnya Loading

jsecretan commented Jul 12, 2019 •

edited

Loading

btlechowski commented Jul 6, 2020 •

edited

Loading

btlechowski commented Jul 10, 2020 •

edited

Loading

btlechowski commented Jul 10, 2020 •

edited by GeetaSarvadnya

Loading