Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear label for unblocking elements #5242

Closed
foxbunny opened this issue Jul 15, 2019 · 3 comments
Closed

Unclear label for unblocking elements #5242

foxbunny opened this issue Jul 15, 2019 · 3 comments
Labels
closed/wontfix feature/CSS-element-block priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@foxbunny
Copy link

foxbunny commented Jul 15, 2019

Description

The Brave context menu says "Block element via selector". To me, a logical opposite of "block" is "unblock". Since I could not find such an item in the context menu, I looked in the settings, and on internet to no avail.

I believe it would improve discovery of the unblock functionality if it were called "Unblock blocked elements ....", rather than "Clear CSS rules ...". Also, the documentation for this feature would be a lot more helpful if it would mention how to reverse the effects, as it's rather easy to make a mistake on sites that use weird auto-generated selectors.

Steps to Reproduce

  1. n/a

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1903 (Build 18362.175)
JavaScript V8 7.5.288.23

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jul 19, 2019
@andria-dev
Copy link

Would "unblock elements" be a little bit better than "unblock blocked elements"?

@balaji303
Copy link

Even I have this issue. Please say how to unblock elements.

@bsclifton
Copy link
Member

Closing as wontfix - we have a new cosmetic filter in place. I created #8914 to track removing this older version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix feature/CSS-element-block priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

5 participants