-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove older cosmetic filter integration from Context Menu? #8914
Comments
Code which can be removed can be found on https://github.com/brave/brave-browser/projects/21 under |
I just found out about this old, deprecated, cosmetic filter (right-click, brave, block element via selector) today when removing gitlab's annoying "README", "Add licence', etc. buttons. Now I find out that it's going away. I can't find any documentation on the new cosmetic filter process. How to add things that way? Hopefully it's as easy as the obsolete way? |
@drq883 this needs to be reviewed with several folks before we make a decision to remove. It's quite possible we can just link this functionality to the new cosmetic filter functionality instead of removing. Right now, they're not related and it's definitely confusing |
@bsclifton #8914 (comment) Exactly. Why not just make the context menu adblock and |
Description
There is a newer cosmetic filter integration which is available which @antonok-edm and @pes10k have worked on. This loads and processes rules that are on lists or are manually supplied on brave://adblock/
We have an older integration which is available by right click under the
Brave
menu. This is basically obsolete now and should be removed:Having both run at the same time can introduce some unstable behavior and it's also confusing for users
Steps to Reproduce
Block element via selector
and other items underBrave
context menu itemThe text was updated successfully, but these errors were encountered: