Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove older cosmetic filter integration from Context Menu? #8914

Closed
bsclifton opened this issue Mar 30, 2020 · 5 comments
Closed

Remove older cosmetic filter integration from Context Menu? #8914

bsclifton opened this issue Mar 30, 2020 · 5 comments

Comments

@bsclifton
Copy link
Member

Description

There is a newer cosmetic filter integration which is available which @antonok-edm and @pes10k have worked on. This loads and processes rules that are on lists or are manually supplied on brave://adblock/

We have an older integration which is available by right click under the Brave menu. This is basically obsolete now and should be removed:
Screen Shot 2020-03-29 at 10 40 07 PM

Having both run at the same time can introduce some unstable behavior and it's also confusing for users

Steps to Reproduce

  1. Visit a web page in Brave
  2. Right click something
  3. Notice there are Block element via selector and other items under Brave context menu item
@bsclifton
Copy link
Member Author

Code which can be removed can be found on https://github.com/brave/brave-browser/projects/21 under Work was finished (may need revert) column

@drq883
Copy link

drq883 commented Apr 24, 2020

I just found out about this old, deprecated, cosmetic filter (right-click, brave, block element via selector) today when removing gitlab's annoying "README", "Add licence', etc. buttons.

Now I find out that it's going away. I can't find any documentation on the new cosmetic filter process. How to add things that way?

Hopefully it's as easy as the obsolete way?

@bsclifton
Copy link
Member Author

bsclifton commented Apr 24, 2020

@drq883 this needs to be reviewed with several folks before we make a decision to remove. It's quite possible we can just link this functionality to the new cosmetic filter functionality instead of removing. Right now, they're not related and it's definitely confusing

@bsclifton bsclifton changed the title Remove older cosmetic filter integration from Context Menu WIP: Remove older cosmetic filter integration from Context Menu Apr 24, 2020
@bsclifton bsclifton added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Apr 24, 2020
@bsclifton bsclifton changed the title WIP: Remove older cosmetic filter integration from Context Menu Remove older cosmetic filter integration from Context Menu? Apr 24, 2020
@bsclifton
Copy link
Member Author

Closing as wontfix; per discussion with @pes10k, we can keep this in place and work towards integrating it with the existing cosmetic filters. Priority for this has not been assigned, so there will continue to be two filters for a bit

For more information on that, please check out:
#9577

@bsclifton bsclifton added this to the Dupe / Invalid / Not actionable milestone May 1, 2020
@antonok-edm antonok-edm removed the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label May 1, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
@ugultopu
Copy link

@bsclifton #8914 (comment) Exactly. Why not just make the context menu adblock and brave://adblock custom filters use that same data store, so that whenever you block something using context menu adblock, the adblock rule for it appears on brave://adblock custom filters (since both are stored in the same place)? I expected it to be this way but apparently it is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants