Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search box overlaps on Crypto wallet #5337

Closed
srirambv opened this issue Jul 23, 2019 · 3 comments · Fixed by brave/brave-core#2991
Closed

Search box overlaps on Crypto wallet #5337

srirambv opened this issue Jul 23, 2019 · 3 comments · Fixed by brave/brave-core#2991
Assignees
Labels
bug design A design change, especially one which needs input from the design team feature/settings priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Search box overlaps on Crypto wallet

Steps to Reproduce

  1. Update to 0.69.77
  2. Open settings page
  3. Increase browser size so that the icons change to texts, search box gets overlapped on the new Crypto Wallet setting

Actual result:

image

Expected result:

No overlapping buttons

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.77 Chromium: 76.0.3809.62 (Official Build) nightly (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc: @petemill @brave/design

@srirambv srirambv added bug design A design change, especially one which needs input from the design team QA/Yes release-notes/include feature/settings labels Jul 23, 2019
@kjozwiak
Copy link
Member

Reproducible on macOS 10.14.5 using the following build:

Brave 0.69.77 Chromium: 76.0.3809.62 (Official Build) nightly (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Example of the issue occurring:

Screen Shot 2019-07-23 at 10 23 39 AM

ryanml added a commit to brave/brave-core that referenced this issue Jul 24, 2019
@ryanml ryanml added this to the 0.70.x - Nightly milestone Jul 24, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 9, 2019
ryanml added a commit to brave/brave-core that referenced this issue Aug 14, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 17, 2019

Verification passed on

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description, increase browser size changes the texts to icons so no overlapping of search icon on crypto wallet

image

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.126 Chromium: 77.0.3865.65 (Official Build) (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS macOS Version 10.14.6 (Build 18G95)

Screen Shot 2019-09-18 at 2 15 12 AM

Screen Shot 2019-09-18 at 2 15 01 AM

Screen Shot 2019-09-18 at 2 14 25 AM

Verification passed on

Brave 0.69.127 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description, increase browser size changes the texts to icons so no overlapping of search icon on crypto wallet

image

@kjozwiak
Copy link
Member

kjozwiak commented Sep 18, 2019

@bbondy @rebron @ryanml the above is still an issue when the window is minimized to the following dimensions:

  • window.outerWidth --> 501
  • window.outerHeight --> 444

@rebron want an issue created for the above? I'm not sure if anyone would even use the browser at that size.

Example:

Screen Shot 2019-09-18 at 2 14 49 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design A design change, especially one which needs input from the design team feature/settings priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants