Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot navigate back to shields from blocked script details view #5338

Closed
srirambv opened this issue Jul 23, 2019 · 2 comments · Fixed by brave/brave-core#3034
Closed

Cannot navigate back to shields from blocked script details view #5338

srirambv opened this issue Jul 23, 2019 · 2 comments · Fixed by brave/brave-core#3034
Assignees
Labels
bug design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Cannot navigate back to shields from blocked script details view

Steps to Reproduce

  1. Visit any site
  2. Enable Block script in shields
  3. Click on Scripts blocked
  4. Click on Go Back button in details view, doesn't work

Actual result:

https://youtu.be/ISjDaoY_f7A

Expected result:

Should take back to shields overview when Go Back button is clicked in detailed view

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.69.77 Chromium: 76.0.3809.62 (Official Build) nightly (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the dev channel? N/A
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc: @cezaraugusto @karenkliu

@srirambv srirambv added bug design A design change, especially one which needs input from the design team QA/Yes release-notes/include feature/shields/panel Front-end design and functionality of the Shields panel. labels Jul 23, 2019
@GeetaSarvadnya
Copy link

The issue is reproducible on Windows 10 x64 - 0.69.77

@btlechowski
Copy link

btlechowski commented Aug 20, 2019

Verification passed on

Brave 0.69.110 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3034
Verified steps from the video https://youtu.be/ISjDaoY_f7A

Verified passed with

Brave 0.69.114 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Verification passed on

Brave 0.69.115 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants