-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebTorrent: Rename "Save File" button to make functionality clearer #5354
Labels
design
A design change, especially one which needs input from the design team
feature/webtorrent
Label for webtorrent related issues
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
rebron
added
design/needs-mock-up
needs-mockup A feature which needs design mockup to be implemented.
design
A design change, especially one which needs input from the design team
and removed
design/needs-mock-up
needs-mockup A feature which needs design mockup to be implemented.
labels
Jul 23, 2019
cc: @rossmoody |
@rossmoody's mocks for the redesign we're discussing in #5402 and on Slack in |
Verification passed on
Verification passed on
Verification PASSED on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
A design change, especially one which needs input from the design team
feature/webtorrent
Label for webtorrent related issues
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Description
When clicking on a .torrent file, the button "Save File" that appears implies to me that the torrent's contents can be saved by clicking it. In fact, this button downloads the .torrent file.
I recommend naming this "Save .torrent File" instead. Feedback from the design team is welcome.
Steps to Reproduce
Actual result:
Expected result:
"Save .torrent File"
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Version 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: