Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebTorrent: Rename "Save File" button to make functionality clearer #5354

Closed
feross opened this issue Jul 23, 2019 · 3 comments · Fixed by brave/brave-core#3036
Closed

WebTorrent: Rename "Save File" button to make functionality clearer #5354

feross opened this issue Jul 23, 2019 · 3 comments · Fixed by brave/brave-core#3036
Assignees
Labels
design A design change, especially one which needs input from the design team feature/webtorrent Label for webtorrent related issues QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@feross
Copy link

feross commented Jul 23, 2019

Description

When clicking on a .torrent file, the button "Save File" that appears implies to me that the torrent's contents can be saved by clicking it. In fact, this button downloads the .torrent file.

I recommend naming this "Save .torrent File" instead. Feedback from the design team is welcome.

Steps to Reproduce

  1. Visit https://webtorrent.io/free-torrents
  2. Click Big Buck Bunny (torrent file)
  3. Start downloading torrent
  4. Look at the "Save File" button

Actual result:

Screen Shot 2019-07-23 at 1 36 05 PM

Expected result:

"Save .torrent File"

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@feross feross added the feature/webtorrent Label for webtorrent related issues label Jul 23, 2019
@feross feross self-assigned this Jul 23, 2019
@rebron rebron added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Jul 23, 2019
@rebron
Copy link
Collaborator

rebron commented Jul 23, 2019

cc: @rossmoody

@feross
Copy link
Author

feross commented Jul 27, 2019

@rossmoody's mocks for the redesign we're discussing in #5402 and on Slack in #webtorrent use this new copy, so let's go ahead with it.

@btlechowski
Copy link

btlechowski commented Sep 18, 2019

Verification passed on

Brave 0.70.96 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

During downloading
image

Downloading is finished
image

Verification passed on

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.126 Chromium: 77.0.3865.65 (Official Build) (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS macOS Version 10.14.6 (Build 18G95)

Screen Shot 2019-09-18 at 12 23 36 PM

Screen Shot 2019-09-18 at 12 23 24 PM

Screen Shot 2019-09-18 at 12 19 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/webtorrent Label for webtorrent related issues QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants